Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DatePicker support kk:mm format #42494

Merged
merged 2 commits into from
May 19, 2023
Merged

feat: DatePicker support kk:mm format #42494

merged 2 commits into from
May 19, 2023

Conversation

cooljser
Copy link
Contributor

@cooljser cooljser commented May 19, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #38141
close #38482

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English timecpiker support kk:mm format。
🇨🇳 Chinese DatePicker 支持 kk:mm 格式的 format 以支持显示 24:00。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at dbd4b75

This pull request adds support for the kk:mm format in the DatePicker component, which displays a time panel with two columns for hours and minutes. It also fixes a bug where the hour column was shown even when the format string did not include any hour symbols.

🔍 Walkthrough

🤖 Generated by Copilot at dbd4b75

  • Hide hour column in time panel if format string does not include 24-hour notation (link)
  • Add test case for DatePicker component with kk:mm format (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ffedddb) 100.00% compared to head (95407d6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #42494   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          640       640           
  Lines        10870     10875    +5     
  Branches      2952      2957    +5     
=========================================
+ Hits         10870     10875    +5     
Impacted Files Coverage Δ
components/date-picker/generatePicker/index.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 6195610 into ant-design:feature May 19, 2023
@MadCcc MadCcc mentioned this pull request Jun 6, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants