New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rewrite Affix CC => FC #42674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for ant-design:
|
li-jia-nan
changed the title
refactor: rewrite Affix CC => FC
refactor: [WIP] rewrite Affix CC => FC
May 27, 2023
size-limit report 📦
|
feature 分支吧 |
OK,我改一下 |
20 tasks
Signed-off-by: lijianan <574980606@qq.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #42674 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 692 692
Lines 11674 11660 -14
Branches 3118 3115 -3
=========================================
- Hits 11674 11660 -14
☔ View full report in Codecov by Sentry. |
li-jia-nan
changed the title
refactor: [WIP] rewrite Affix CC => FC
refactor: rewrite Affix CC => FC
Sep 27, 2023
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
li-jia-nan
commented
Sep 27, 2023
kiner-tang
approved these changes
Sep 28, 2023
Co-authored-by: kiner-tang(文辉) <1127031143@qq.com> Signed-off-by: lijianan <574980606@qq.com>
看下覆盖率。 |
afc163
reviewed
Oct 7, 2023
Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: lijianan <574980606@qq.com>
补上了大佬 |
afc163
reviewed
Oct 7, 2023
终于有 PR 是减 bundlesize 的了~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 5a4959b
Refactored the
Affix
component to use React hooks and simplified its props and style. Adjusted the import order of types incomponents/input-number/style/index.ts
for code style consistency.🔍 Walkthrough
🤖 Generated by Copilot at 5a4959b
Affix
component from class to functional using hooks (link, link, link)components/input-number/style/index.ts
to follow convention of importing types after other imports (link)