Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite Affix CC => FC #42674

Merged
merged 36 commits into from Oct 7, 2023
Merged

refactor: rewrite Affix CC => FC #42674

merged 36 commits into from Oct 7, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented May 27, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English refactor: rewrite Affix CC => FC
🇨🇳 Chinese 重构为函数组件

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 5a4959b

Refactored the Affix component to use React hooks and simplified its props and style. Adjusted the import order of types in components/input-number/style/index.ts for code style consistency.

🔍 Walkthrough

🤖 Generated by Copilot at 5a4959b

  • Refactor Affix component from class to functional using hooks (link, link, link)
  • Adjust import order in components/input-number/style/index.ts to follow convention of importing types after other imports (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2023

@github-actions
Copy link
Contributor

Pull reviewers stats

Stats of the last 30 days for ant-design:

User Total reviews Time to review Total comments
li-jia-nan 80 1h 9m 61
afc163 78 1h 26m 58
MadCcc 66 2d 21h 27m 138
kiner-tang 33 11m 11
yoyo837 24 49m 25
zombieJ 22 1h 14m 13
RedJue 8 4h 6m 11
PeachScript 3 19m 0
RexSkz 2 48m 5
vagusX 1 1h 36m 0
arvinxx 1 46m 12
Wxh16144 1 21m 3
sawadyecma 1 1h 51m 2
bombillazo 1 23h 49m 1

@li-jia-nan li-jia-nan changed the title refactor: rewrite Affix CC => FC refactor: [WIP] rewrite Affix CC => FC May 27, 2023
@li-jia-nan li-jia-nan marked this pull request as draft May 27, 2023 11:03
@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 397.68 KB (-204 B 🔽)
./dist/antd-with-locales.min.js 456.99 KB (-199 B 🔽)

@afc163
Copy link
Member

afc163 commented May 27, 2023

feature 分支吧

@li-jia-nan li-jia-nan changed the base branch from master to feature May 27, 2023 18:50
@li-jia-nan
Copy link
Member Author

feature 分支吧

OK,我改一下

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e1f3b79) 100.00% compared to head (7132267) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #42674   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          692       692           
  Lines        11674     11660   -14     
  Branches      3118      3115    -3     
=========================================
- Hits         11674     11660   -14     
Files Coverage Δ
components/_util/throttleByAnimationFrame.ts 100.00% <100.00%> (ø)
components/affix/index.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan changed the title refactor: [WIP] rewrite Affix CC => FC refactor: rewrite Affix CC => FC Sep 27, 2023
@argos-ci
Copy link

argos-ci bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 7 changes Oct 7, 2023, 9:14 AM

components/affix/index.tsx Outdated Show resolved Hide resolved
components/affix/index.tsx Outdated Show resolved Hide resolved
li-jia-nan and others added 3 commits September 28, 2023 09:02
Co-authored-by: kiner-tang(文辉) <1127031143@qq.com>
Signed-off-by: lijianan <574980606@qq.com>
@afc163
Copy link
Member

afc163 commented Oct 7, 2023

看下覆盖率。

li-jia-nan and others added 2 commits October 7, 2023 10:34
Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: lijianan <574980606@qq.com>
@li-jia-nan li-jia-nan requested a review from afc163 October 7, 2023 03:02
@li-jia-nan
Copy link
Member Author

看下覆盖率。

补上了大佬

@li-jia-nan li-jia-nan requested a review from afc163 October 7, 2023 08:13
@afc163 afc163 merged commit be92498 into feature Oct 7, 2023
87 checks passed
@afc163 afc163 deleted the affix-r branch October 7, 2023 10:53
@afc163
Copy link
Member

afc163 commented Oct 7, 2023

终于有 PR 是减 bundlesize 的了~

@li-jia-nan li-jia-nan mentioned this pull request Oct 14, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants