type(affix): optimize InternalAffixProps type #43578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #43578 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 11048 11048
Branches 2991 2991
=========================================
Hits 11048 11048
☔ View full report in Codecov by Sentry. |
li-jia-nan
reviewed
Jul 15, 2023
| @@ -43,6 +43,7 @@ export interface AffixProps { | |||
|
|
|||
| interface InternalAffixProps extends AffixProps { | |||
| affixPrefixCls: string; | |||
| onTestUpdatePosition?: () => void; | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
修改的是内部的props，不影响对外暴露的类型，然后这边类型添加的是参考test文件中的
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 1233ec5
Enhance testing of
updatePositionmethod inAffixcomponent. AddonTestUpdatePositionprop and remove type assertion incomponents/affix/index.tsx.🔍 Walkthrough
🤖 Generated by Copilot at 1233ec5
onTestUpdatePositiontoInternalAffixPropsto testupdatePositionmethod (link)as anyfromonTestUpdatePositionprop inInternalAffixcomponent (link)