fix: record the completed length of the last calculation as the transison length #43058
+82
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
20 tasks
bbb169
changed the title
afc163
approved these changes
Jul 10, 2023
|
ci 挂了 |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #43058 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 665 665
Lines 11276 11280 +4
Branches 3048 3049 +1
=========================================
+ Hits 11276 11280 +4
☔ View full report in Codecov by Sentry. |
|
@MadCcc 看看 |
kiner-tang
approved these changes
Aug 23, 2023
bbb169
force-pushed
the
fixEllipsisShake
branch
2 times, most recently
from
bba0531
to
4893325
Compare
…tion width in the calculation
bbb169
force-pushed
the
fixEllipsisShake
branch
from
4893325
to
6fe22c5
Compare
|
这个 Demo 挂了： 
|
bbb169
force-pushed
the
fixEllipsisShake
branch
from
5b53a54
to
a974bc0
Compare
zombieJ
reviewed
Aug 30, 2023
|
|
||
| it('should not throw default dom nodes', async () => { | ||
| let currentWidth = 100; | ||
| // string conut is different with different width |
zombieJ
approved these changes
Aug 30, 2023
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #42958
💡 Background and solution
The bug is caused by below codes:
if (!enabledMeasure || walkingState !== DONE_WITH_ELLIPSIS) {
return children(nodeList, false);
}
when ellipsis is walking, will use all the nodelist as temporary text, this caused space is not enough, so page scroll bar will show up
solution is record the completed length of the last calculation as the transition length in the calculation
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 741a1de
Improve ellipsis feature in
Typographycomponent by reusing optimal text length. RefactorEllipsis.tsxto use a state variablelastLen.🔍 Walkthrough
🤖 Generated by Copilot at 741a1de
lastLento store the last length of the text that was successfully rendered with ellipsis (link, link)lastLenas a temporary width for the text if it exists, to avoid rendering the text with the full length and then shrinking it, which could cause unnecessary layout shifts and performance issues (link)