Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Tabs): refactor closeIcon #43098

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Jun 19, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Tabs support hidden close button when closeIcon setting to null or false
🇨🇳 Chinese 标签页组件支持通过设置 closeIcon 为 null 或 false 隐藏关闭按钮

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 358a0f6

Added the ability to hide the close button of tabs by setting the closeIcon property to null or false. Updated the documentation and the rc-tabs dependency accordingly.

🔍 Walkthrough

🤖 Generated by Copilot at 358a0f6

  • Upgrade rc-tabs dependency to version 12.8.1 to enable hiding close button feature (link)
  • Add closeIcon property to TabItemType in English and Chinese documentation and explain how to hide close button by setting it to null or false (link, link)
  • Reorder closable property in TabItemType to keep alphabetical order (link, link)

@kiner-tang kiner-tang requested a review from zombieJ June 19, 2023 08:17
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
rc-tabs 🆕 12.8.1 None +0 157 kB zombiej

Footnotes

  1. https://docs.socket.dev

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 376.85 KB (+35 B 🔺)
./dist/antd-with-locales.min.js 436.29 KB (+55 B 🔺)

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4af6a52) 100.00% compared to head (358a0f6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #43098   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          650       650           
  Lines        10956     10984   +28     
  Branches      2971      2980    +9     
=========================================
+ Hits         10956     10984   +28     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiner-tang kiner-tang merged commit 18ffb00 into feature Jun 19, 2023
@kiner-tang kiner-tang deleted the refactor-tabs-closeIcon branch June 19, 2023 12:14
@kiner-tang kiner-tang changed the title refactor: refactor closeIcon refactor(Tabs): refactor closeIcon Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants