fix(Form): solve form label offset not working in vertical layout issue #43155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
size-limit report 📦
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #43155 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 648 648
Lines 10961 10961
Branches 2975 2975
=========================================
Hits 10961 10961
☔ View full report in Codecov by Sentry. |
afc163
reviewed
Jun 24, 2023
| @@ -389,7 +389,6 @@ const genInlineStyle: GenerateStyle<FormToken> = (token) => { | |||
| }; | |||
|
|
|||
| const makeVerticalLayoutLabel = (token: FormToken): CSSObject => ({ | |||
| margin: 0, | |||
There was a problem hiding this comment.
我也是心慌慌，但是 cicleCI 至今申诉无果，提了 n 个工单都没有回音
afc163
approved these changes
Jun 24, 2023
20 tasks
|
还是不生效啊？5.11.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #43154
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 1efe15f
Refactored the
formstyle module and removed unnecessary code. This improves the readability and consistency of thecomponents/form/style/index.tsfile.🔍 Walkthrough
🤖 Generated by Copilot at 1efe15f
genInlineStylefunction to avoid duplication and conflicts withgenFormStylefunction (link)