Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Form): solve form label offset not working in vertical layout issue #43155

Merged
merged 1 commit into from
Jun 24, 2023
Merged

fix(Form): solve form label offset not working in vertical layout issue #43155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions components/form/style/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import type { CSSObject } from '@ant-design/cssinjs';
import { resetComponent } from '../../style';
import { genCollapseMotion, zoomIn } from '../../style/motion';
import type { AliasToken, FullToken, GenerateStyle } from '../../theme/internal';
import { genComponentStyleHook, mergeToken } from '../../theme/internal';
import { resetComponent } from '../../style';
import genFormValidateMotionStyle from './explain';

export interface FormToken extends FullToken<'Form'> {
Expand Down Expand Up @@ -389,7 +389,6 @@ const genInlineStyle: GenerateStyle<FormToken> = (token) => {
};

const makeVerticalLayoutLabel = (token: FormToken): CSSObject => ({
margin: 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有 argos 慌的很。

Copy link
Member

@afc163 afc163 Jun 24, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看上去没啥问题 #43159

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我也是心慌慌，但是 cicleCI 至今申诉无果，提了 n 个工单都没有回音

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单独开了一个 PR 测：#43159

padding: `0 0 ${token.paddingXS}px`,
whiteSpace: 'initial',
textAlign: 'start',
Expand Down