-
-
Notifications
You must be signed in to change notification settings - Fork 48.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Avatar.Group support shape props #43817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
size-limit report 📦
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
MadCcc
reviewed
Jul 26, 2023
Co-authored-by: MadCcc <1075746765@qq.com> Signed-off-by: lijianan <574980606@qq.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #43817 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 11143 11146 +3
Branches 3017 3018 +1
=========================================
+ Hits 11143 11146 +3
☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Jul 26, 2023
kiner-tang
approved these changes
Jul 27, 2023
MadCcc
reviewed
Jul 27, 2023
MadCcc
reviewed
Jul 27, 2023
MadCcc
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 8060644
Added a
shape
prop to theAvatar
andAvatar.Group
components to enable square avatars. Updated theAvatar
component to use the newAvatarContext
from theSizeContext
file. Added a new demo and documentation for theshape
prop. Fixed some minor style issues.🔍 Walkthrough
🤖 Generated by Copilot at 8060644
shape
prop toAvatar
andAvatar.Group
components to allow square avatars (link, link, link, link, link, link, link, link, link, link)AvatarContext
type to passshape
andsize
props fromAvatar.Group
toAvatar
(link, link, link, link)cloneElement
function inAvatar.Group
to only passkey
prop to children (link)maxPopoverPlacement
andmaxPopoverTrigger
props inAvatar.Group
(link)style
prop inAvatar.Group
(link, link, link)shape
prop inAvatar.Group
incomponents/avatar/demo/group.tsx
(link)