Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: optimize site style in mobile #43895

Merged
merged 2 commits into from
Jul 30, 2023
Merged

site: optimize site style in mobile #43895

merged 2 commits into from
Jul 30, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Jul 30, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English site: optimize site style in mobile
🇨🇳 Chinese 删除官网 Breadcrumb 废弃语法,优化移动端样式,无需纳入ChangeLog

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 3d95480

Improved the mobile responsiveness and readability of the documentation theme and refactored some components for consistency and clarity. Annotated some components with React.FC type and removed unnecessary whitespace in components/modal/useModal/index.tsx.

🔍 Walkthrough

🤖 Generated by Copilot at 3d95480

  • Annotate ComponentItem and AuthorAvatar components with React.FC type for better type checking and readability (link, link)
  • Refactor Breadcrumb component to use items prop instead of children prop for conciseness and consistency (link)
  • Use useContext hook and SiteContext to access isMobile value and conditionally render prev and next navigation links in PrevAndNext component (link, link, link)
  • Add listMobile style and apply it to ContributorsList component based on isMobile value in Content component (link, link, link)
  • Format if statements with braces and new lines in Content component for readability and consistency (link)
  • Remove empty line in useModal component to remove unnecessary whitespace (link)
  • Remove outdated comment about custom author info in Content component (link)

@stackblitz
Copy link

stackblitz bot commented Jul 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 382.43 KB
./dist/antd-with-locales.min.js 441.98 KB

@argos-ci
Copy link

argos-ci bot commented Jul 30, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Jul 30, 2023, 11:04 AM

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (6cc3c2c) 99.98% compared to head (9701a26) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #43895      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files         659       657       -2     
  Lines       11850     11076     -774     
  Branches     3307      2996     -311     
===========================================
- Hits        11848     11076     -772     
+ Misses          2         0       -2     
Files Changed Coverage Δ
components/modal/useModal/index.tsx 100.00% <ø> (+2.53%) ⬆️

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan requested a review from zombieJ July 30, 2023 11:04
@li-jia-nan li-jia-nan merged commit 41d0a77 into master Jul 30, 2023
88 checks passed
@li-jia-nan li-jia-nan deleted the site-op branch July 30, 2023 11:16
yoyo837 pushed a commit that referenced this pull request Jul 30, 2023
* site: ptimize site style in mobile

* fix
li-jia-nan added a commit that referenced this pull request Jul 30, 2023
* site: optimize site style in mobile (#43895)

* site: ptimize site style in mobile

* fix

* fix: 合并冲突时注释错行

---------

Co-authored-by: lijianan <574980606@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants