Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix comment and feature merge master #43899

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jul 30, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 2b0d22e

This pull request improves the documentation site layout and style, refactors some components to use better props and types, and enhances the readability of some test cases and code files. It mainly affects the .dumi folder and the components/modal folder.

🔍 Walkthrough

🤖 Generated by Copilot at 2b0d22e

  • Annotate ComponentItem and AuthorAvatar components with React.FC type for better type checking and readability (link, link)
  • Refactor Breadcrumb component to use items prop instead of children prop for conciseness and consistency (link)
  • Import useContext hook and SiteContext and SiteContextProps types to access site context values (link, link)
  • Retrieve isMobile value from site context to determine device type (link, link)
  • Conditionally render PrevAndNext component based on isMobile value to avoid showing navigation buttons on mobile devices (link)
  • Apply listMobile style to ContributorsList component based on isMobile value to adjust layout on mobile devices (link)
  • Move comments explaining test steps to new lines for readability and clarity in hook.test.tsx (link)
  • Remove empty line and redundant comment for code style and accuracy in useModal/index.tsx and Content/index.tsx (link, link)
  • Move cache prop to front of ContributorsList component for convention and readability (link)

@stackblitz
Copy link

stackblitz bot commented Jul 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 383.72 KB
./dist/antd-with-locales.min.js 443.2 KB

@argos-ci
Copy link

argos-ci bot commented Jul 30, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 4 changes Jul 30, 2023, 2:10 PM

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d7cc34f) 100.00% compared to head (2b0d22e) 100.00%.
Report is 1 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #43899   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        11157     11157           
  Branches      3018      3018           
=========================================
  Hits         11157     11157           
Files Changed Coverage Δ
components/modal/useModal/index.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit b7eefe5 into feature Jul 30, 2023
92 checks passed
@li-jia-nan li-jia-nan deleted the feature-merge-master-2 branch July 30, 2023 14:22
@yoyo837 yoyo837 mentioned this pull request Jul 30, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants