Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AutoComplete): AutoComplete support rootClassName #44055

Merged
merged 11 commits into from
Aug 8, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Aug 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English AutoComplete support rootClassName
🇨🇳 Chinese AutoComplete 支持 rootClassName

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 7ba2971

This pull request adds a new prop rootClassName to the AutoComplete component, which enables users to customize the class name of the popup element. It also updates the tests, demos and documentation to reflect the new prop.

🔍 Walkthrough

🤖 Generated by Copilot at 7ba2971

  • Add rootClassName prop to AutoComplete component to allow customizing the root element and the popup element of the component (link, link, link)
  • Update the documentation of the AutoComplete component in both English and Chinese to include the rootClassName prop and its details (link, link)
  • Add the rootClassName prop to the basic demo of the AutoComplete component to show its usage and effect (link)
  • Add a test case for the rootClassName prop of the AutoComplete component to verify that the custom root class name is applied to the element (link)

@stackblitz
Copy link

stackblitz bot commented Aug 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 386.69 KB
./dist/antd-with-locales.min.js 445.83 KB

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6ca1b6d) 100.00% compared to head (b18afb2) 100.00%.
Report is 34 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff             @@
##           feature    #44055    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          658       658            
  Lines        11166     11368   +202     
  Branches      3024      3099    +75     
==========================================
+ Hits         11166     11368   +202     
Files Changed Coverage Δ
components/_util/wave/index.ts 100.00% <ø> (ø)
components/_util/wave/style.ts 100.00% <ø> (ø)
components/anchor/style/index.ts 100.00% <ø> (ø)
components/checkbox/style/index.ts 100.00% <ø> (ø)
components/config-provider/context.ts 100.00% <ø> (ø)
...date-picker/generatePicker/generateRangePicker.tsx 100.00% <ø> (ø)
...ate-picker/generatePicker/generateSinglePicker.tsx 100.00% <ø> (ø)
components/drawer/style/index.ts 100.00% <ø> (ø)
components/input-number/style/index.ts 100.00% <ø> (ø)
components/input/style/index.ts 100.00% <ø> (ø)
... and 13 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
@kiner-tang kiner-tang requested a review from zombieJ August 7, 2023 12:21
@kiner-tang kiner-tang merged commit 9d122a6 into feature Aug 8, 2023
85 checks passed
@kiner-tang kiner-tang deleted the feat-autocomplete-rootClassName branch August 8, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants