fix: Form 与 Grid 样式冲突问题 #44472
Merged
fix: Form 与 Grid 样式冲突问题 #44472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
size-limit report 📦
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #44472 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 661 661
Lines 11231 11272 +41
Branches 3042 3060 +18
=========================================
+ Hits 11231 11272 +41
☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Aug 28, 2023
zombieJ
reviewed
Aug 28, 2023
| @@ -92,7 +93,7 @@ const genLoopGridColumnsStyle = (token: GridColToken, sizeCls: string): CSSObjec | |||
| const gridColumnsStyle: CSSObject = {}; | |||
| for (let i = gridColumns; i >= 0; i--) { | |||
| if (i === 0) { | |||
| gridColumnsStyle[`${componentCls}${sizeCls}-${i}`] = { | |||
| gridColumnsStyle[`${componentCls}${componentCls}${componentCls}${sizeCls}-${i}`] = { | |||
zombieJ
approved these changes
Aug 28, 2023
20 tasks
20 tasks
This was referenced Sep 29, 2023
This was referenced Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close: #44456
💡 Background and solution
📝 Changelog
wrapperCol.span为0时，子元素不隐藏的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at cc0ab4e
This pull request enhances the grid component's style customization by adding a
rootPrefixClsparameter to its style functions and hooks. This allows users to change the class name prefix for the grid elements incomponents/grid/style/index.ts.🔍 Walkthrough
🤖 Generated by Copilot at cc0ab4e
rootPrefixClsparameter to grid style functions and pass it togenLoopGridColumnsStylefunction to generate class name prefix for grid columns (link, link, link, link, link)gridColumnsStyleobject in another object with.${rootPrefixCls}-rowkey to target grid row element ingenGridStylefunction (link)rootPrefixClsproperty to second argument ofgenComponentStyleHookfunction call inuseColStylefunction, which is a custom hook that returns style objects for grid column component (link)components/grid/style/index.tsfile for code formatting and readability (link)