Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Form style should always before Grid #44485

Merged
merged 5 commits into from Aug 29, 2023
Merged

refactor: Form style should always before Grid #44485

merged 5 commits into from Aug 29, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 29, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

follow up #44472
close #44491
close #44495

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Adjust Form style order that will be insert before Grid style to ensure Grid style take effect when has same selector priority with Form.
🇨🇳 Chinese 调整 From 样式插入顺序在 Grid 之前,确保相同 css 优先级下首选 Grid 样式以解决在响应式布局下 Grid 设置不生效的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 8d11b65

This pull request refactors and fixes the style generation for the form and grid components, and enhances the utility function for creating component style hooks. It extracts the input style to a separate function genInputStyle, adds an order option to the genComponentStyleHook function, and moves the grid style from components/grid/style/index.ts to components/form/style/index.ts.

🔍 Walkthrough

🤖 Generated by Copilot at 8d11b65

  • Refactor the form and grid style to improve readability and fix a bug (link, link, link, link, link)
  • Add the order option to the genComponentStyleHook function to customize the insertion order of the style (link, link, link, link, link, link)

@stackblitz
Copy link

stackblitz bot commented Aug 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 389.08 KB (+221 B 🔺)
./dist/antd-with-locales.min.js 447.96 KB (+223 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 6 changes Aug 29, 2023, 7:32 AM

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fae1fef) 100.00% compared to head (511bc97) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #44485     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          673       663     -10     
  Lines        12405     11254   -1151     
  Branches      3384      3045    -339     
===========================================
- Hits         12405     11254   -1151     
Files Changed Coverage Δ
components/form/FormItemInput.tsx 100.00% <ø> (ø)
components/form/style/fallbackCmp.ts 100.00% <100.00%> (ø)
components/form/style/index.ts 100.00% <100.00%> (ø)
components/grid/style/index.ts 100.00% <100.00%> (ø)
components/theme/util/genComponentStyleHook.ts 100.00% <100.00%> (ø)

... and 55 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants