New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Form style should always before Grid #44485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
MadCcc
approved these changes
Aug 29, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #44485 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 673 663 -10
Lines 12405 11254 -1151
Branches 3384 3045 -339
===========================================
- Hits 12405 11254 -1151
☔ View full report in Codecov by Sentry. |
This was referenced Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
follow up #44472
close #44491
close #44495
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 8d11b65
This pull request refactors and fixes the style generation for the form and grid components, and enhances the utility function for creating component style hooks. It extracts the input style to a separate function
genInputStyle
, adds anorder
option to thegenComponentStyleHook
function, and moves the grid style fromcomponents/grid/style/index.ts
tocomponents/form/style/index.ts
.🔍 Walkthrough
🤖 Generated by Copilot at 8d11b65
order
option to thegenComponentStyleHook
function to customize the insertion order of the style (link, link, link, link, link, link)