New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spin): Adds fullscreen
property to <Spin />
component
#44986
feat(spin): Adds fullscreen
property to <Spin />
component
#44986
Conversation
Run & review this pull request in StackBlitz Codeflow. |
|
PR to feature branch please. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
fullscreen
property to <Spin />
componentfullscreen
property to <Spin />
component
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #44986 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 695 695
Lines 11709 11712 +3
Branches 3128 3131 +3
=========================================
+ Hits 11709 11712 +3
☔ View full report in Codecov by Sentry. |
fullscreen
property to <Spin />
componentfullscreen
property to <Spin />
component
I automated the close action in the demo with 2s: ant-d.fullscren.auto.mp4We can also set a close button instead, not sure what is the best approach 🤔 |
I don’t know if Gaussian blur will look good, |
Designer’s discussion result: change dots to |
also use the bgmask as background, removing the bgColor token
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Create a solution similar to https://mui.com/material-ui/api/backdrop/ but inside the
<Spin />
component📝 Changelog
Added a new prop called
fullscreen
that adds a css class to make it behave as it should.Video
ant-d.spin.fullscreen.mp4
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at b2fa189
This pull request adds a new feature to the
Spin
component that allows it to display a fullscreen spinner and handle click events. It also adds a new demo, documentation, and style for the feature. The files affected arecomponents/spin/index.tsx
,components/spin/style/index.tsx
,components/spin/demo/fullscreen.md
,components/spin/demo/fullscreen.tsx
, andcomponents/spin/index.en-US.md
.🔍 Walkthrough
🤖 Generated by Copilot at b2fa189
fullscreen
andonClick
to the Spin component (link, link, link, link)components/spin/style/index.tsx
(link, link)