Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spin): Adds fullscreen property to <Spin /> component #44986

Merged
merged 23 commits into from Oct 19, 2023

Conversation

Rafael-Martins
Copy link
Contributor

@Rafael-Martins Rafael-Martins commented Sep 20, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Create a solution similar to https://mui.com/material-ui/api/backdrop/ but inside the <Spin /> component

📝 Changelog

Added a new prop called fullscreen that adds a css class to make it behave as it should.

Video

ant-d.spin.fullscreen.mp4
Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at b2fa189

This pull request adds a new feature to the Spin component that allows it to display a fullscreen spinner and handle click events. It also adds a new demo, documentation, and style for the feature. The files affected are components/spin/index.tsx, components/spin/style/index.tsx, components/spin/demo/fullscreen.md, components/spin/demo/fullscreen.tsx, and components/spin/index.en-US.md.

🔍 Walkthrough

🤖 Generated by Copilot at b2fa189

  • Add a new fullscreen demo for the Spin component (link, link, link)
  • Add new props fullscreen and onClick to the Spin component (link, link, link, link)
  • Add style definition for the fullscreen spinner in components/spin/style/index.tsx (link, link)

@stackblitz
Copy link

stackblitz bot commented Sep 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

  • 🚨 Please fill changelog in the PR

    • Write with a developer-oriented perspective and narrative method, without describing the details of the repair
    • Describing the problem and the impact on the developer
    • describing the user-first site problem, not your solution
    • Refer: https://ant.design/changelog#501
  • 🚨 请填写 PR 中的 changelog

    • 请用面向开发者的角度叙述方式撰写,不描述修复细节
    • 描述问题和对开发者的影响
    • 描述用户第一现场的问题,而非你的解决方式
    • 参考:https://ant.design/changelog-cn#501

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

@li-jia-nan
Copy link
Member

PR to feature branch please.

@argos-ci
Copy link

argos-ci bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Oct 19, 2023, 3:15 AM

@Rafael-Martins Rafael-Martins changed the base branch from master to feature September 21, 2023 18:03
@Rafael-Martins Rafael-Martins changed the title WIP: Adds fullscreen property to <Spin /> component Adds fullscreen property to <Spin /> component Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2e8e67f) 100.00% compared to head (d52779a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #44986   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          695       695           
  Lines        11709     11712    +3     
  Branches      3128      3131    +3     
=========================================
+ Hits         11709     11712    +3     
Files Coverage Δ
components/spin/index.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rafael-Martins Rafael-Martins changed the title Adds fullscreen property to <Spin /> component feat(spin): Adds fullscreen property to <Spin /> component Sep 21, 2023
components/spin/index.en-US.md Outdated Show resolved Hide resolved
components/spin/index.zh-CN.md Outdated Show resolved Hide resolved
components/spin/style/index.tsx Outdated Show resolved Hide resolved
components/spin/index.tsx Outdated Show resolved Hide resolved
components/spin/style/index.tsx Outdated Show resolved Hide resolved
components/spin/index.tsx Outdated Show resolved Hide resolved
@Rafael-Martins
Copy link
Contributor Author

I automated the close action in the demo with 2s:

ant-d.fullscren.auto.mp4

We can also set a close button instead, not sure what is the best approach 🤔

@Brucia323
Copy link
Contributor

I don’t know if Gaussian blur will look good, backdrop-filter: blur(8px);

@li-jia-nan
Copy link
Member

li-jia-nan commented Oct 7, 2023

Designer’s discussion result: change dots to #fff,and mask reuses Modal mask's backgroundColor.

li-jia-nan and others added 2 commits October 8, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants