[pull] master from ant-design:master #232

pull · 2023-11-19T00:27:51Z

See Commits and Changes for more details.

Can you help keep this open source service alive? 💖 Please sponsor : )

* docs: init * chore: update example * test: update test * docs: update doc * chore: fix lint * chore: update limit

* feat: add ref * feat: table support reference * chore: rename * chore: proxy * test: add test case * chore: fix lint * docs: update desc * docs: update desc * docs: update desc * chore: clean up * chore: fix lint

chore: feature merge master

* feat: App support component * test: update test case * chore: update ts

* docs: init * feat: support inherit * test: update snapshot

chore: merge master into feature

* chore: bump rc-input-number * test: update test case

* chore: bump rc-tabs * chore: update limit * chore: fix lint

chore: feature merge master

* fix: dropdown not trigger onOpenChange when click menu item * chore: add source * docs: update * test: update test

* feat: start the implementation of the fullscreen prop in Spin * docs: change main spin demo * docs: enhance demo * test: update snapshot * fix: address pr comments * fix: use logical property on fullscreen class * fix: address pr review * feat: Added background color token * fix: remove onClick and change demo * feat: change spin to white when fullcreen also use the bgmask as background, removing the bgColor token * fix: unused import * test: update snapshot * Update components/spin/style/index.tsx Signed-off-by: lijianan <574980606@qq.com> * fix: use white color from token * fix: not needed interpolation and version * fix: address pr review * fix: tip prop was not working * test: cover tip & fullscreen case * fix: addrress pr coments --------- Signed-off-by: lijianan <574980606@qq.com> Co-authored-by: lijianan <574980606@qq.com> Co-authored-by: MadCcc <1075746765@qq.com>

* feat: z-index manager * feat: z-index manager * feat: update snap * chore: update site-limit * feat: optimize code * feat: optimize code * feat: add test case * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code

chore: merge master into feature

* feat: Popconfirm support z-index manager * Update components/popconfirm/__tests__/index.test.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

* feat: Popover support z-index manager * feat: update snap * Update components/popover/__tests__/index.test.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

* feat: Tooltip support z-index manager * feat: optimize code

Co-authored-by: afc163 <afc163@users.noreply.github.com>

… was abnormal in the pop-up container (#45864) * fix: Fixed an issue where the z-index setting of the pop-up component was abnormal in the pop-up container * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * Update components/popconfirm/index.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

* 📖docs: update tabs component docs * Update components/tabs/index.zh-CN.md Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: yufamg <99855951+yufamg@users.noreply.github.com> * Update components/tabs/index.en-US.md Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: yufamg <99855951+yufamg@users.noreply.github.com> --------- Signed-off-by: yufamg <99855951+yufamg@users.noreply.github.com> Co-authored-by: afc163 <afc163@gmail.com>

* chore(deps-dev): bump size-limit from 10.0.3 to 11.0.0 Bumps [size-limit](https://github.com/ai/size-limit) from 10.0.3 to 11.0.0. - [Changelog](https://github.com/ai/size-limit/blob/main/CHANGELOG.md) - [Commits](ai/size-limit@10.0.3...11.0.0) --- updated-dependencies: - dependency-name: size-limit dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: afc163 <afc163@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: afc163 <afc163@gmail.com>

Co-authored-by: zbw01218944 <zbw01218944@alibaba-inc.com>

* fix: disabled btn with link should not be focused * chore: update snapshot * chore: update snapshot

* docs: update Nextjs docs * Update use-with-next.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update use-with-next.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> * update * Update use-with-next.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update use-with-next.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> --------- Signed-off-by: lijianan <574980606@qq.com>

* chore: add image to Next.js doc * Update use-with-next.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update use-with-next.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> --------- Signed-off-by: lijianan <574980606@qq.com>

* feat: export sider context from layout * refactor: use internal naming

* fix: zIndex miss of message * fix: modal static index * test: update snapshot * test: update snapshot * test: update snapshot * test: fix zIndex test * test: update test case * chore: clean up * test: coverage

* chore: migrate to webpack@5 * Revert "feat: support popupBg and darkPopupBg (#45826)" This reverts commit 496ac33. * chore: update

* docs: changelog for 5.11.2 * chore: bump version to 5.11.2 * docs: update changelog

Signed-off-by: Peach <scdzwyxst@gmail.com>

* docs: update Modal.method docs * docs: update Modal.method US docs

semanticdiff-com · 2023-11-19T00:27:55Z

Review changes with SemanticDiff

restack-app · 2023-11-19T00:27:55Z

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

commit-lint · 2023-11-19T00:27:57Z

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

pr-code-reviewer · 2023-11-19T00:27:57Z

👋 Hi there!

Everything looks good!

_{^{Automatically generated with the help of gpt-3.5-turbo.

Feedback? Please don't hesitate to drop me an email at webber@takken.io.}}

coderabbitai · 2023-11-19T00:27:57Z

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

If you reply to a review comment from CodeRabbit, the bot will automatically respond.
To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
Note: Review comments are made on code diffs or files, not on the PR overview.
Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

instapr · 2023-11-19T00:28:02Z

The pull request looks good overall. Just a few minor suggestions:

In the README.md file, consider adding more details about the purpose and usage of the service.
It would be helpful to include some unit tests to ensure the code behaves as expected.
Double-check the formatting and indentation in the files you've modified. There are a few inconsistencies.
Consider adding a code comment in the utils.py file to explain the purpose of the do_something() function.

Great job on the changes! 🎉

github-actions · 2023-11-19T00:28:02Z

Hi @pull[bot]。

请注意，当前 PR 是分支间的互相合并，请使用 BranchAutoMerge 标签来进行自动合并。切记不要、不要、不要使用 Squash。

github-actions · 2023-11-19T00:28:05Z

Hi @pull[bot]. Thanks for your contribution. But, we don't have plan to add README of more languages. This current PR will be closed and team members will help on this.

github-actions · 2023-11-19T00:28:06Z

github-actions · 2023-11-19T00:28:06Z

Hi @pull[bot]. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

sweep-ai · 2023-11-19T00:28:56Z

Apply Sweep Rules to your PR?

Apply: All new business logic should have corresponding unit tests.
Apply: Refactor large functions to be more modular.
Apply: Add docstrings to all functions and file headers.

pr-explainer-bot · 2023-11-19T00:29:20Z

Pull Request Review Markdown Doc

Hey there! It's time to summarize the previous results and write a Pull Request review markdown doc. Let's get started!

Greetings

Hello team! I hope you're all doing well. I've reviewed the pull request and here's what I found:

Changes

Added support for customizing components in the Table with virtual attribute.
Fixed a bug where the Button with href and disabled could still be focused.
Fixed a logic problem with zIndex that caused messages and notifications to be covered when multiple Modal are opened.
Fixed the style.padding issue with QRCode.
Optimized the Carousel dots border radius style.
Optimized the List gutter property type definition.

Suggestions

In the file components/_util/hooks/useProxyImperativeHandle.ts, consider using a Proxy object instead of manually filling a proxy object. This can simplify the code and make it more readable. Specifically, you can replace the fillProxy function with a Proxy object that handles the get trap to check if the property exists in the refObj and return it if it does. This will eliminate the need for the fillProxy function and make the code more concise.

Bugs

There are no potential bugs mentioned in the changelog.

Improvements

In the file components/_util/hooks/useProxyImperativeHandle.ts, the code can be refactored to improve readability. Instead of manually filling a proxy object, you can use a Proxy object to handle the get trap and check if the property exists in the refObj. Here's an example of how the code can be refactored:

export default function useProxyImperativeHandle<
  NativeELementType extends HTMLElement,
  ReturnRefType extends { nativeElement: Native

Rating

Please rate the code from 0 to 10 based on the following criteria:

Readability
Performance
Security

Please provide a brief explanation for your rating.

Premium Plan

By the way, did you know that we offer a premium plan that can analyze big pull requests? It's perfect for those times when your pull requests are larger than life. Just something to keep in mind!

That's all for now. Let me know if you need any further assistance. Happy coding!

zombieJ and others added 30 commits October 10, 2023 16:22

feat: Input & TextArea support count (#45140)

6af1d95

* docs: init * chore: update example * test: update test * docs: update doc * chore: fix lint * chore: update limit

feat: Table support scrollTo reference (#45245)

bef9539

* feat: add ref * feat: table support reference * chore: rename * chore: proxy * test: add test case * chore: fix lint * docs: update desc * docs: update desc * docs: update desc * chore: clean up * chore: fix lint

Merge pull request #45271 from ant-design/master

012e878

chore: feature merge master

feat: App support component (#45292)

eaf4949

* feat: App support component * test: update test case * chore: update ts

feat: Watermark support inherit to disable passing (#45319)

44e1493

* docs: init * feat: support inherit * test: update snapshot

Merge branch master into master-merge-feature

8b486f3

Merge branch master into master-merge-feature

5b47f16

feat: update snap

442e175

Merge branch 'master' into master-merge-feature

0de095c

fix: update snap

bb6ef6f

Merge branch 'master' into master-merge-feature

00d74a3

fix: update snap

f9e5547

feat: update snap

1474006

feat: update snap

cb7e11a

Merge pull request #45347 from ant-design/master-merge-feature

e62197a

chore: merge master into feature

fix: InputNumber dynamic formatter (#45325)

9a04519

* chore: bump rc-input-number * test: update test case

feat: Tabs items support destroyInactiveTabPane (#45359)

98a8d30

chore: bump rc-tabs (#45370)

11cdac4

* chore: bump rc-tabs * chore: update limit * chore: fix lint

Merge pull request #45381 from ant-design/master

d8140e0

chore: feature merge master

fix: dropdown not trigger onOpenChange when click menu item (#45378)

a337fee

* fix: dropdown not trigger onOpenChange when click menu item * chore: add source * docs: update * test: update test

feat: support dirty (#45389)

3ab42ad

feat: support changeOnBlur (#45395)

2e8e67f

Merge branch 'feature' into refactor-z-index-context

d51de67

chore: auto merge branches (#45444)

f25fd3c

chore: merge master into feature

Merge branch 'feature' into refactor-z-index-context

bff04cd

feat: Popconfirm support z-index manager (#45421)

0fd730a

* feat: Popconfirm support z-index manager * Update components/popconfirm/__tests__/index.test.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

feat: Popover support z-index manager (#45420)

8c49b38

* feat: Popover support z-index manager * feat: update snap * Update components/popover/__tests__/index.test.tsx Signed-off-by: kiner-tang(文辉) <1127031143@qq.com> --------- Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

feat: Tooltip support z-index manager (#45422)

bf1468a

* feat: Tooltip support z-index manager * feat: optimize code

github-actions bot and others added 16 commits November 14, 2023 02:37

chore: upgrade deps (#45851)

ac39eab

Co-authored-by: afc163 <afc163@users.noreply.github.com>

chore: bump table (#45857)

a5649f1

site(Header): increase z-index (#45890)

f0a2695

Co-authored-by: zbw01218944 <zbw01218944@alibaba-inc.com>

fix: disabled btn with link should not be focused (#45910)

2dda417

* fix: disabled btn with link should not be focused * chore: update snapshot * chore: update snapshot

chore: add image to Next.js doc (#45929)

dd05e18

* chore: add image to Next.js doc * Update use-with-next.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update use-with-next.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> --------- Signed-off-by: lijianan <574980606@qq.com>

chore: script update (#45937)

29126fe

feat: export sider context from layout (#45916)

9078b2b

* feat: export sider context from layout * refactor: use internal naming

fix: zIndex miss of message (#45911)

dc25579

* fix: zIndex miss of message * fix: modal static index * test: update snapshot * test: update snapshot * test: update snapshot * test: fix zIndex test * test: update test case * chore: clean up * test: coverage

revert: menu token (#45939)

6cfbace

* chore: migrate to webpack@5 * Revert "feat: support popupBg and darkPopupBg (#45826)" This reverts commit 496ac33. * chore: update

docs: changelog for 5.11.2 (#45946)

d13aad6

* docs: changelog for 5.11.2 * chore: bump version to 5.11.2 * docs: update changelog

chore: correct type error in theme file (#45949)

aec6a80

Signed-off-by: Peach <scdzwyxst@gmail.com>

docs: update Modal.method docs (#45948)

a308dcf

* docs: update Modal.method docs * docs: update Modal.method US docs

github-actions bot closed this Nov 19, 2023

pull bot added the ⤵️ pull label Nov 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] master from ant-design:master #232

[pull] master from ant-design:master #232

pull bot commented Nov 19, 2023 •

edited

semanticdiff-com bot commented Nov 19, 2023

restack-app bot commented Nov 19, 2023

commit-lint bot commented Nov 19, 2023

pr-code-reviewer bot commented Nov 19, 2023 •

edited

coderabbitai bot commented Nov 19, 2023

Auto Review Skipped

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

instapr bot commented Nov 19, 2023

github-actions bot commented Nov 19, 2023

github-actions bot commented Nov 19, 2023

github-actions bot commented Nov 19, 2023

github-actions bot commented Nov 19, 2023

sweep-ai bot commented Nov 19, 2023

pr-explainer-bot bot commented Nov 19, 2023

[pull] master from ant-design:master #232

[pull] master from ant-design:master #232

Conversation

pull bot commented Nov 19, 2023 • edited

semanticdiff-com bot commented Nov 19, 2023

restack-app bot commented Nov 19, 2023

commit-lint bot commented Nov 19, 2023

Features

Bug Fixes

Chore

Contributors

pr-code-reviewer bot commented Nov 19, 2023 • edited

👋 Hi there!

coderabbitai bot commented Nov 19, 2023

Auto Review Skipped

Chat with CodeRabbit Bot (@coderabbitai)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

instapr bot commented Nov 19, 2023

github-actions bot commented Nov 19, 2023

github-actions bot commented Nov 19, 2023

github-actions bot commented Nov 19, 2023

github-actions bot commented Nov 19, 2023

sweep-ai bot commented Nov 19, 2023

Apply Sweep Rules to your PR?

pr-explainer-bot bot commented Nov 19, 2023

Pull Request Review Markdown Doc

Greetings

Changes

Suggestions

Bugs

Improvements

Rating

Premium Plan

pull bot commented Nov 19, 2023 •

edited

pr-code-reviewer bot commented Nov 19, 2023 •

edited

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Configration File (`.coderabbit.yaml`)