New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Watermark support inherit to disable passing #45319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
issue link |
crazyair
reviewed
Oct 13, 2023
size-limit report 📦
|
kiner-tang
approved these changes
Oct 13, 2023
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
crazyair
approved these changes
Oct 13, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #45319 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 693 693
Lines 11696 11700 +4
Branches 3124 3127 +3
=========================================
+ Hits 11696 11700 +4
☔ View full report in Codecov by Sentry. |
This was referenced Nov 3, 2023
This was referenced Nov 9, 2023
This was referenced Nov 16, 2023
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
inherit
prop to disable watermark pass to Drawer & Modal.inherit
配置,关闭水印传导至弹出 Drawer 与 Modal。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at fd080eb
This pull request adds a new
inherit
prop to theWatermark
component, which allows users to control whether the watermark effect is inherited by the nested components or not. It also updates the demo, the tests, and the documentation files to reflect the new feature.🔍 Walkthrough
🤖 Generated by Copilot at fd080eb
inherit
to the Watermark component, which controls whether the watermark appears in the portal components such as Drawer or not (link, link, link, link).