New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dropdown not trigger onOpenChange when click menu item #45378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
MadCcc
approved these changes
Oct 17, 2023
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
zombieJ
force-pushed
the
dropdown-open
branch
from
October 17, 2023 03:59
b13ca6e
to
488d235
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #45378 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 695 695
Lines 11707 11709 +2
Branches 3127 3128 +1
=========================================
+ Hits 11707 11709 +2
☔ View full report in Codecov by Sentry. |
This was referenced Nov 3, 2023
This was referenced Nov 9, 2023
This was referenced Nov 16, 2023
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
ref #45371
💡 Background and solution
📝 Changelog
onOpenChange
when click menu item to close the popup.onOpenChange
的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at b13ca6e
This pull request fixes a bug in the
Dropdown
component that prevented the menu from closing after selecting an item. It adds a test case and a line of code to call theonOpenChange
prop withfalse
incomponents/dropdown/__tests__/index.test.tsx
andcomponents/dropdown/dropdown.tsx
, respectively.🔍 Walkthrough
🤖 Generated by Copilot at b13ca6e