Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update tag default background #45700

Merged
merged 3 commits into from
Nov 7, 2023
Merged

fix: update tag default background #45700

merged 3 commits into from
Nov 7, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Nov 7, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #45694

after:

dark:
image
light:
image

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English update tag default background
🇨🇳 Chinese 修改标签的默认背景颜色

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at f8a2c6e

This pull request improves the accessibility and consistency of the tag component's style. It uses TinyColor to manipulate the background color based on colorBgContainer and adjusts the text color accordingly.

🔍 Walkthrough

🤖 Generated by Copilot at f8a2c6e

  • Import TinyColor library to manipulate colors for tag component (link)
  • Change default background color of tag component to colorBgContainer for better contrast and accessibility (link)

Copy link

stackblitz bot commented Nov 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Nov 7, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 400.74 KB (-3 B 🔽)
./dist/antd-with-locales.min.js 460.09 KB (-2 B 🔽)

Copy link

codesandbox-ci bot commented Nov 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fee8c86:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

argos-ci bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 7, 2023, 9:53 AM

@afc163
Copy link
Member

afc163 commented Nov 7, 2023

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3fc8ed) 100.00% compared to head (fee8c86) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45700   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          700       700           
  Lines        11826     11826           
  Branches      3151      3151           
=========================================
  Hits         11826     11826           
Files Coverage Δ
components/tag/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 380649e into master Nov 7, 2023
94 checks passed
@afc163 afc163 deleted the fix-tag-default-bg branch November 7, 2023 10:28
@kiner-tang kiner-tang mentioned this pull request Nov 8, 2023
20 tasks
@zombieJ zombieJ mentioned this pull request Nov 9, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag default background colour will show the bottom colour through
2 participants