Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update tag default background #45711

Merged
merged 1 commit into from Nov 8, 2023
Merged

fix: update tag default background #45711

merged 1 commit into from Nov 8, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Nov 8, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #45694

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English update tag default background
🇨🇳 Chinese 修改标签的默认背景颜色

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 7b2b77e

Improved tag contrast and accessibility with TinyColor. Changed components/tag/style/index.ts to adjust tag background color based on text color.

🔍 Walkthrough

🤖 Generated by Copilot at 7b2b77e

  • Adjust tag background color based on container background color using TinyColor library (link, link)

Copy link

stackblitz bot commented Nov 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Nov 8, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 400.78 KB (+34 B 🔺)
./dist/antd-with-locales.min.js 460.12 KB (+30 B 🔺)

Copy link

codesandbox-ci bot commented Nov 8, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7b2b77e:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c614e81) 100.00% compared to head (7b2b77e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45711   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          700       700           
  Lines        11826     11826           
  Branches      3151      3151           
=========================================
  Hits         11826     11826           
Files Coverage Δ
components/tag/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiner-tang kiner-tang merged commit b3cb6b3 into master Nov 8, 2023
100 checks passed
@kiner-tang kiner-tang deleted the fix-tag-default-bg2 branch November 8, 2023 02:43
@zombieJ zombieJ mentioned this pull request Nov 9, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag default background colour will show the bottom colour through
2 participants