Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Checkout component react16 typescript error #46962

Merged
merged 1 commit into from Jan 13, 2024
Merged

Conversation

crazyair
Copy link
Member

@crazyair crazyair commented Jan 13, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

react 16/17 下 typescript 会提示错误
Pasted Graphic 9

📝 Changelog

Language Changelog
🇺🇸 English fix Checkout component react16 typescript error
🇨🇳 Chinese 修复 Checkout 组件 react16 typescript 报错

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 13, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 13, 2024

Visual Regression Report for PR #46962 Passed ✅

Target branch: master (78de319)


Congrats! No visual-regression diff found

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 331.04 KB
./dist/antd-with-locales.min.js 376.97 KB

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d9d662c:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78de319) 100.00% compared to head (d9d662c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46962   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12548     12548           
  Branches      3291      3291           
=========================================
  Hits         12548     12548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit 72e4980 into master Jan 13, 2024
113 checks passed
@li-jia-nan li-jia-nan deleted the fix-checkout-type branch January 13, 2024 21:53
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@afc163
Copy link
Member

afc163 commented Jan 14, 2024

能否给一下重现?

@crazyair
Copy link
Member Author

能否给一下重现?

antd 安装下 @types/react 16版本,查看这个 demo 就能看到报错

@MadCcc MadCcc mentioned this pull request Jan 15, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants