Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changelog 5.13.1 #46973

Merged
merged 3 commits into from
Jan 15, 2024
Merged

docs: changelog 5.13.1 #46973

merged 3 commits into from
Jan 15, 2024

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Jan 15, 2024


  • 🐞 修复 Checkbox 组件在 React@16 版本下 Typescript 报错。#46962 @crazyair

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 15, 2024

Visual Regression Report for PR #46973 Passed ✅

Target branch: master (2cd0b40)


Congrats! No visual-regression diff found

Copy link
Contributor

github-actions bot commented Jan 15, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 15, 2024

🎉 Verify package version passed!

PR package version PR title version
5.13.1 5.13.1

CHANGELOG.zh-CN.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 15, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 331.01 KB (-27 B 🔽)
./dist/antd-with-locales.min.js 376.88 KB (-95 B 🔽)

Copy link

codesandbox-ci bot commented Jan 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 67587c5:

Sandbox Source
antd reproduction template (forked) Configuration

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: MadCcc <1075746765@qq.com>
CHANGELOG.en-US.md Outdated Show resolved Hide resolved
Signed-off-by: MadCcc <1075746765@qq.com>
@li-jia-nan
Copy link
Member

低版本的 @types/react 18 也存在问题

@yoyo837
Copy link
Contributor

yoyo837 commented Jan 15, 2024

低版本的 @types/react 18 也存在问题

知道最低哪个版本的18是OK的吗?那日志文件可以写 16、17、18@xx以下

@afc163
Copy link
Member

afc163 commented Jan 15, 2024

18 里的低版本就不解决了,没办法兼容每一个子版本的,能升级就让用户升级。

@crazyair
Copy link
Member

18 里的低版本就不解决了,没办法兼容每一个子版本的,能升级就让用户升级。

已经解决了,现在是 changelog 要不要透出 18,我觉得可以不用加。

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cd0b40) 100.00% compared to head (67587c5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46973   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12548     12548           
  Branches      3291      3291           
=========================================
  Hits         12548     12548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit fd002d7 into master Jan 15, 2024
106 checks passed
@MadCcc MadCcc deleted the docs/5.13.1 branch January 15, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants