Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locale es_ES (Spanish) #5932

Merged
merged 2 commits into from
Apr 28, 2017

Conversation

ginodeis
Copy link
Contributor

Hi,

First of all, thanks and congratulations for this great project.

I have found some translation problems using the package with es_ES locale and continuing with the PR #1471 I have tried to correct them.

I have updated rc-pagination component too, to support es_ES locale.

Thanks @benjycui for your help.

@mention-bot
Copy link

@ginodeis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjycui, @afc163 and @yesmeck to be potential reviewers.

okText: 'OK',
cancelText: 'Cancelar',
okText: 'OK',
cancelText: 'Cancelar',
Copy link
Member

@afc163 afc163 Apr 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't modify the indent, which should be 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm stupid.

@enzolutions
Copy link

Hi @afc163 && @ginodeis

I am interested in this PR to be part of next release if there is a guide to follow to resolve the CI issues I could help to address.

Kind regards,

@benjycui
Copy link
Contributor

👍

@benjycui benjycui merged commit 5c25452 into ant-design:feature-2.10 Apr 28, 2017
@enzolutions
Copy link

Hi @benjycui

Thanks, I have a question regards released the 2.10 will be release after 2.9.3?

Kind regards,

@benjycui
Copy link
Contributor

We will release antd@2.10 in a week

@enzolutions
Copy link

@ginodeis

Thanks for your contribution, with the new version 2.10.0 now the calendar is working in Spanish.

But, I have a concern about the basic label like validation "% is required" is not in Spanish despite it's inside a Local Provider.

Any suggestions?

Buen trabajo.

@benjycui
Copy link
Contributor

benjycui commented May 8, 2017

@enzolutions validation's locales are not under the control of LocaleProvider, more: https://github.com/yiminghe/async-validator/

@enzolutions
Copy link

@benjycui

Thank for your response.

but "% is required" and other are inside antd code, should be possible to contribute a translation of that standard message?

Any ideas?

@benjycui
Copy link
Contributor

@enzolutions #6082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants