Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support autoAdjustOverflow prop, in another way. #6661

Merged

Conversation

jdz321
Copy link
Contributor

@jdz321 jdz321 commented Jun 29, 2017

the same to #6652 but no change in rc-tooltip

@jdz321
Copy link
Contributor Author

jdz321 commented Jun 29, 2017

related discuss : react-component/tooltip#88 (comment)

@jdz321 jdz321 changed the title support autoAdjustOverflow prop, in another why. support autoAdjustOverflow prop, in another way. Jun 29, 2017
@afc163
Copy link
Member

afc163 commented Jun 30, 2017

  1. CI breaks.
  2. we should update documentation for Popover Popconfirm too.

@jdz321
Copy link
Contributor Author

jdz321 commented Jun 30, 2017

  1. CI 报错是其他地方的问题, 不在这次commit修
  2. Popover & Popconfirm 已经提示了 更多属性请参考 Tooltip , 没必要再单列这个prop

@afc163
Copy link
Member

afc163 commented Jun 30, 2017

👍

@benjycui
Copy link
Contributor

Rebase 一下

@jdz321 jdz321 force-pushed the feat-auto-adjust-overflow-beta branch from ebfd9a2 to 6f5d368 Compare June 30, 2017 06:25
@jdz321
Copy link
Contributor Author

jdz321 commented Jun 30, 2017

@benjycui done.

@jdz321 jdz321 force-pushed the feat-auto-adjust-overflow-beta branch from 6f5d368 to 87b0337 Compare June 30, 2017 06:51
@codecov
Copy link

codecov bot commented Jun 30, 2017

Codecov Report

Merging #6661 into feature-2.12 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##           feature-2.12    #6661      +/-   ##
================================================
+ Coverage         84.17%   84.17%   +<.01%     
================================================
  Files               224      224              
  Lines              4859     4860       +1     
  Branches           1399     1399              
================================================
+ Hits               4090     4091       +1     
  Misses              769      769
Impacted Files Coverage Δ
components/tooltip/index.tsx 92.77% <100%> (ø) ⬆️
components/tooltip/placements.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc9d4ae...87b0337. Read the comment docs.

@benjycui benjycui merged commit 9dcc28e into ant-design:feature-2.12 Jun 30, 2017
@afc163
Copy link
Member

afc163 commented Jul 2, 2017

close #6625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants