Skip to content

Conversation

jdz321
Copy link

@jdz321 jdz321 commented Jun 28, 2017

A shortcut option to setup feature autoAdjustOverflow

no disruptive changes

see ant-design/ant-design#6625

@jdz321 jdz321 changed the title ✨ support autoAdjustOverflow prop support autoAdjustOverflow prop Jun 28, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8bf81bb on jdz321:feat-auto-adjust-overflow into ** on react-component:master**.

@benjycui
Copy link
Member

I don't think that we need to modify rc-tooltip, just like antd.Tooltip[arrowPointAtCenter], it should be part of antd.Tooltip not rc-tooltip.

@jdz321
Copy link
Author

jdz321 commented Jun 29, 2017

因为这个配置 rc-tooltip 也同样适用的
如果不需要的话我可以写个不修改rc-tootip的,也可以的。

@benjycui
Copy link
Member

功能上看放哪里都行。

不过就 API 设计的一致性来看,觉得没必要放进 rc-tooltip 而已。

@afc163
Copy link
Member

afc163 commented Jun 30, 2017

对,rc-tooltip 已经有了相应的 API 了。我也觉得放在 antd.Tooltip 作为语法糖即可。

@afc163 afc163 closed this Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants