Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List:add infinite & detail optimize #7445

Merged
merged 10 commits into from
Sep 6, 2017
Merged

Conversation

nikogu
Copy link
Contributor

@nikogu nikogu commented Sep 4, 2017

@@ -0,0 +1,53 @@
---
order: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

都是第一个。。。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我改改。。。忽略了这个细节 =。-

@codecov
Copy link

codecov bot commented Sep 5, 2017

Codecov Report

Merging #7445 into antd-3.0 will decrease coverage by 0.98%.
The diff coverage is 44.04%.

Impacted file tree graph

@@             Coverage Diff              @@
##           antd-3.0    #7445      +/-   ##
============================================
- Coverage     86.95%   85.97%   -0.99%     
============================================
  Files           252      252              
  Lines          5160     5234      +74     
  Branches       1428     1446      +18     
============================================
+ Hits           4487     4500      +13     
- Misses          673      734      +61
Impacted Files Coverage Δ
components/list/Item.tsx 100% <100%> (ø) ⬆️
components/list/index.tsx 40.77% <40.5%> (-59.23%) ⬇️
components/menu/index.tsx 96.11% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abdf14c...e34abfb. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Sep 5, 2017

Add some test?

}

export default class List extends Component<ListProps> {
static Item: typeof Item = Item;

static childContextTypes = {
grid: PropTypes.any,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个为啥叫 grid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个跟 Card 保持一致

@yesmeck
Copy link
Member

yesmeck commented Sep 5, 2017

这个 infinite loading 感觉没必要在组件内部实现?可以有独立的组件实现吧,比如 https://github.com/CassetteRocks/react-infinite-scroller

还有如果要做无限加载的话是不是还要实现 virtualization

@afc163
Copy link
Member

afc163 commented Sep 5, 2017

对,最好把 virtualization 的功能内建到 List 里。这样 List 可以作为纯粹的逻辑组件和各种自定义列表配合。

@nikogu
Copy link
Contributor Author

nikogu commented Sep 5, 2017

这个 infinite loading 感觉没必要在组件内部实现?可以有独立的组件实现吧,比如 https://github.com/CassetteRocks/react-infinite-scroller

内部实现更方便一点?他只用关心逻辑就好了,loading 一般都标准化了,类似 Table?好像独立组件实现没有什么优势,除了可以灵活定制样式(不过一般我们 loading 的样子都视觉规范好了)?

@nikogu
Copy link
Contributor Author

nikogu commented Sep 5, 2017

virtualization 后面可以搞个...

@nikogu nikogu mentioned this pull request Sep 6, 2017
@nikogu nikogu changed the base branch from antd-3.0 to master September 6, 2017 06:25
@nikogu nikogu changed the base branch from master to antd-3.0 September 6, 2017 06:25
@nikogu
Copy link
Contributor Author

nikogu commented Sep 6, 2017

pro 那边需要,先合了,其他功能已经记录到:#4905

@nikogu nikogu merged commit bceb15c into antd-3.0 Sep 6, 2017
@nikogu nikogu deleted the list-functional-enhance branch September 6, 2017 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants