-
-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List:add infinite & detail optimize #7445
Conversation
components/list/demo/meta.md
Outdated
@@ -0,0 +1,53 @@ | |||
--- | |||
order: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
都是第一个。。。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我改改。。。忽略了这个细节 =。-
Codecov Report
@@ Coverage Diff @@
## antd-3.0 #7445 +/- ##
============================================
- Coverage 86.95% 85.97% -0.99%
============================================
Files 252 252
Lines 5160 5234 +74
Branches 1428 1446 +18
============================================
+ Hits 4487 4500 +13
- Misses 673 734 +61
Continue to review full report at Codecov.
|
Add some test? |
} | ||
|
||
export default class List extends Component<ListProps> { | ||
static Item: typeof Item = Item; | ||
|
||
static childContextTypes = { | ||
grid: PropTypes.any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个为啥叫 grid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个跟 Card
保持一致
这个 infinite loading 感觉没必要在组件内部实现?可以有独立的组件实现吧,比如 https://github.com/CassetteRocks/react-infinite-scroller 还有如果要做无限加载的话是不是还要实现 virtualization。 |
对,最好把 virtualization 的功能内建到 List 里。这样 List 可以作为纯粹的逻辑组件和各种自定义列表配合。 |
内部实现更方便一点?他只用关心逻辑就好了,loading 一般都标准化了,类似 Table?好像独立组件实现没有什么优势,除了可以灵活定制样式(不过一般我们 loading 的样子都视觉规范好了)? |
virtualization 后面可以搞个... |
pro 那边需要,先合了,其他功能已经记录到:#4905 |
React.children.map
->context
0034d05#commitcomment-23935894