deps: upgrade rc-menu, and close: #2837 #8058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjycui
commented
Oct 30, 2017
|
|
||
| class SubMenu extends React.Component<any, any> { | ||
| static contextTypes = { | ||
| antdMenuTheme: PropTypes.string, |
There was a problem hiding this comment.
重构后，子菜单默认是渲染到 body 下面，所以无法再用 CSS Selector 实现 theme，所以用 context 传递
benjycui
commented
Oct 30, 2017
| @@ -44,6 +44,8 @@ More layouts with navigation: [layout](/components/layout). | |||
| | onDeselect | callback executed when a menu item is deselected, only supported for multiple mode | function({ item, key, selectedKeys }) | - | | |||
| | onOpenChange | called when open/close sub menu | function(openKeys: string\[]) | noop | | |||
| | onSelect | callback executed when a menu item is selected | function({ item, key, selectedKeys }) | none | | |||
| | subMenuOpenDelay | delay time to show submenu when mouse enter, unit: second | number | 0 | | |||
| | subMenuCloseDelay | delay time to hide submenu when mouse leave, unit: second | number | 0.1 | | |||
|
CI broken. |
|
现在测试需要 mock rc-trigger（因为 enzyme 不支持 createPortal），但是 dist 的文件没办法 mock。需要考虑下是不是不针对 dist 文件跑测试了，还是怎么搞下。 |
|
Could #8089 be fixed in antd 2.x? |
afc163
reviewed
Nov 4, 2017
| role="menu" | ||
| style="height:100%" | ||
| tabindex="0" | ||
| > | ||
| <li | ||
| class="ant-menu-submenu-inline ant-menu-submenu-open ant-menu-submenu-selected ant-menu-submenu" | ||
| class="ant-menu-submenu ant-menu-submenu-inline ant-menu-light ant-menu-submenu-open ant-menu-submenu-selected" |
|
涉及到 rc-trigger 的组件我来统一升下好了。 |
|
Close, trace: #8150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #2837
Close: #8089