Don't change fileList when beforeUpload returns false

[yesmeck]

Close #8036

[codecov]

Codecov Report

Merging #8299 into master will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #8299      +/-   ##
=========================================
+ Coverage   83.76%     84%   +0.23%     
=========================================
  Files         209     209              
  Lines        4226    4270      +44     
  Branches     1251    1278      +27     
=========================================
+ Hits         3540    3587      +47     
+ Misses        686     683       -3

Impacted Files	Coverage Δ
components/upload/Upload.tsx	73.04% <ø> (+1.73%)	⬆️
components/form/FormItem.tsx	98.23% <0%> (+1.4%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72741db...b5193e4. Read the comment docs.

[afc163]

应该把 fistList 直接剔除掉。

[yesmeck]

Updated.

[yesmeck]

这个问题不好解，如果这里 fileList 返回空，那么 #7762 的问题又会出现（见 PR 里的用例）。作为变通， #7762 里给的 codepen 可以改成基于 this.state.fileList 去做验证。建议 revert #7773。

@afc163 @nikogu

[yesmeck]

想多了，还是可以的。。

[kikyousky]

I think this issue is not properly fixed for ver 2.13.11, original fileList was replaced by the unacceptable file in onChange callback

  beforeUpload = (file: UploadFile, fileList: UploadFile[]) => {
    if (!this.props.beforeUpload) {
      return true;
    }
    const result = this.props.beforeUpload(file, fileList);
    if (result === false) {
      this.onChange({
        file,
        fileList,
      }, false);
      return false;
    } else if (result && (result as PromiseLike<any>).then) {
      return result;
    }
    return true;
  }
  onChange = (info: UploadChangeParam, updateState = true) => {
    if (!('fileList' in this.props) && updateState) {
      this.setState({ fileList: info.fileList }); //didn't set state when beforeUpload returns false
    }
    const { onChange } = this.props;
    if (onChange) {
      onChange(info); // the fileList in info only contains the unacceptable file, not the expected current file list , 
    }
  }

[yesmeck]

@kikyousky I found this problem too, do you have any advise?