fixed typo error. #8542
Merged
fixed typo error. #8542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8542 +/- ##
=======================================
Coverage 84.96% 84.96%
=======================================
Files 226 226
Lines 4657 4657
Branches 1360 1360
=======================================
Hits 3957 3957
Misses 700 700Continue to review full report at Codecov.
|
yesmeck
reviewed
Dec 11, 2017
| @@ -148,7 +148,7 @@ $ yarn add babel-plugin-import --dev | |||
| Remove the `@import '~antd/dist/antd.css';` statement added before because `babel-plugin-import` will import styles and import components like below: | |||
|
|
|||
| ```diff | |||
| // scr/App.js | |||
| // src/App.js | |||
yesmeck
reviewed
Dec 11, 2017
| @@ -148,7 +148,7 @@ $ yarn add babel-plugin-import --dev | |||
| Remove the `@import '~antd/dist/antd.css';` statement added before because `babel-plugin-import` will import styles and import components like below: | |||
|
|
|||
| ```diff | |||
| // scr/App.js | |||
| // src/App.js | |||
| import React, { Component } from 'react'; | |||
| - import Button from 'antd/lib/button'; | |||
| + import { Button } from 'antd'; | |||
There was a problem hiding this comment.
I did not change that line.
The original file has -, + symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master, feature for latest active branchfeature-x.x.npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :