Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): fix transformKeySubmitValue will gen null value error #2571

Merged
merged 3 commits into from
Apr 22, 2021

Conversation

chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Apr 22, 2021

close #2570

@github-actions
Copy link

github-actions bot commented Apr 22, 2021

🎊 PR Preview has been successfully built and deployed to https://pro-components-preview-pr-2571.surge.sh

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 22, 2021

This pull request introduces 1 alert when merging 7497208 into 7f0cab6 - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@github-actions
Copy link

size-limit report

Path Size
packages/card/dist/card.js 19.08 KB (0%)
packages/descriptions/dist/descriptions.js 20.71 KB (0%)
packages/field/dist/field.js 133.1 KB (0%)
packages/form/dist/form.js 60.89 KB (0%)
packages/layout/dist/layout.js 88.6 KB (0%)
packages/list/dist/list.js 142.24 KB (0%)
packages/provider/dist/provider.js 11.74 KB (0%)
packages/skeleton/dist/skeleton.js 5.19 KB (0%)
packages/table/dist/table.js 47.67 KB (0%)

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #2571 (7497208) into master (7f0cab6) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 7497208 differs from pull request most recent head c2c37c1. Consider uploading reports for the commit c2c37c1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2571      +/-   ##
==========================================
- Coverage   99.14%   99.12%   -0.02%     
==========================================
  Files         171      171              
  Lines        5138     5140       +2     
  Branches     1847     1848       +1     
==========================================
+ Hits         5094     5095       +1     
- Misses         43       44       +1     
  Partials        1        1              
Impacted Files Coverage Δ
...ackages/utils/src/transformKeySubmitValue/index.ts 97.56% <50.00%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f0cab6...c2c37c1. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 22, 2021

This pull request introduces 1 alert when merging c2c37c1 into 7f0cab6 - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@chenshuai2144 chenshuai2144 merged commit c3e5118 into master Apr 22, 2021
@chenshuai2144 chenshuai2144 deleted the fix#2570 branch April 22, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛[BUG] omitNil为false的情况下ProForm initialValues无法给字段初始化设置为null
1 participant