Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): 🐛 DrawerForm cannot get form instance by formRef #4421

Merged
merged 3 commits into from
Jan 9, 2022

Conversation

Dunqing
Copy link
Collaborator

@Dunqing Dunqing commented Jan 6, 2022

fixes: #4418

DrawerForm中设置destroyOnClose=true时,无法获取表单实例,因为visible === false不渲染表单

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

🎊 PR Preview has been successfully built and deployed to https://pro-components-preview-pr-4421.surge.sh

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 6, 2022

This pull request introduces 1 alert when merging 91dfae2 into e8a2f2a - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #4421 (2e168f1) into master (e8a2f2a) will increase coverage by 0.01%.
The diff coverage is 95.45%.

❗ Current head 2e168f1 differs from pull request most recent head 09e7ba3. Consider uploading reports for the commit 09e7ba3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4421      +/-   ##
==========================================
+ Coverage   99.54%   99.55%   +0.01%     
==========================================
  Files         189      189              
  Lines        6347     6349       +2     
  Branches     2247     2246       -1     
==========================================
+ Hits         6318     6321       +3     
  Misses         28       28              
+ Partials        1        0       -1     
Impacted Files Coverage Δ
packages/descriptions/src/index.tsx 98.43% <90.90%> (-0.76%) ⬇️
packages/field/src/components/Text/index.tsx 100.00% <100.00%> (ø)
packages/form/src/layouts/DrawerForm/index.tsx 96.62% <100.00%> (ø)
...ages/layout/src/components/PageContainer/index.tsx 100.00% <100.00%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a2f2a...09e7ba3. Read the comment docs.

@Dunqing Dunqing changed the title fix: 🐛 DrawerForm cannot get form instance by formRef fix(form): 🐛 DrawerForm cannot get form instance by formRef Jan 6, 2022
@chenshuai2144 chenshuai2144 merged commit 179ac82 into ant-design:master Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛[BUG] DrawerForm formRef 绑定不上的问题 (Version-1.52.6)
2 participants