Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(table): fix react dom props warning #512

Merged
merged 2 commits into from
Sep 16, 2020
Merged

🐛 fix(table): fix react dom props warning #512

merged 2 commits into from
Sep 16, 2020

Conversation

chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Sep 16, 2020

close #229

@github-actions
Copy link

github-actions bot commented Sep 16, 2020

🎊 PR Preview e782ffa has been successfully built and deployed to https://ant-design-pro-components-preview-pr-512.surge.sh

🕐 Build time: 752.25s

🤖 By surge-preview

@github-actions
Copy link

⚡️ Deploying PR Preview 8f633f4 to surge.sh ... Build logs

🤖 By surge-preview

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 16, 2020

This pull request introduces 1 alert when merging 8f633f4 into f546937 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #512 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #512   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files         130      130           
  Lines        3590     3590           
  Branches     1288     1288           
=======================================
  Hits         3000     3000           
  Misses        584      584           
  Partials        6        6           
Impacted Files Coverage Δ
packages/table/src/Form/index.tsx 84.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f546937...7c197d3. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 16, 2020

size-limit report

Path Size
packages/card/lib/cardLoading.js, packages/card/lib/index.js 4.04 KB (0%)
packages/card/es/cardLoading.js, packages/card/es/index.js 3.8 KB (0%)
packages/descriptions/lib/index.js, packages/descriptions/lib/useFetchData.js 5.61 KB (0%)
packages/descriptions/es/index.js, packages/descriptions/es/useFetchData.js 5.1 KB (0%)
packages/field/lib/index.js, packages/field/lib/components/Code/index.js, packages/field/lib/components/DatePicker/index.js, packages/field/lib/components/Digit/index.js, packages/field/lib/components/IndexColumn/index.js, packages/field/lib/components/Money/index.js, packages/field/lib/components/Options/index.js, packages/field/lib/components/Percent/index.js, packages/field/lib/components/Percent/util.js, packages/field/lib/components/Progress/index.js, packages/field/lib/components/RangePicker/index.js, packages/field/lib/components/Select/index.js, packages/field/lib/components/Status/index.js, packages/field/lib/components/Text/index.js, packages/field/lib/components/TextArea/index.js, packages/field/lib/components/TimePicker/index.js, packages/field/lib/components/Select/LightSelect/index.js 31.89 KB (0%)
packages/field/es/index.js, packages/field/es/components/Code/index.js, packages/field/es/components/DatePicker/index.js, packages/field/es/components/Digit/index.js, packages/field/es/components/IndexColumn/index.js, packages/field/es/components/Money/index.js, packages/field/es/components/Options/index.js, packages/field/es/components/Percent/index.js, packages/field/es/components/Percent/util.js, packages/field/es/components/Progress/index.js, packages/field/es/components/RangePicker/index.js, packages/field/es/components/Select/index.js, packages/field/es/components/Status/index.js, packages/field/es/components/Text/index.js, packages/field/es/components/TextArea/index.js, packages/field/es/components/TimePicker/index.js, packages/field/es/components/Select/LightSelect/index.js 26.55 KB (0%)
packages/form/lib/FieldContext.js, packages/form/lib/index.js, packages/form/lib/BaseForm/index.js, packages/form/lib/BaseForm/LightWrapper/index.js, packages/form/lib/components/Checkbox/index.js, packages/form/lib/components/DatePicker/DatePicker.js, packages/form/lib/components/DatePicker/MonthPicker.js, packages/form/lib/components/DatePicker/QuarterPicker.js, packages/form/lib/components/DatePicker/WeekPicker.js, packages/form/lib/components/DatePicker/YearPicker.js, packages/form/lib/components/DatePicker/index.js, packages/form/lib/components/DateRangePicker/index.js, packages/form/lib/components/DateTimePicker/index.js, packages/form/lib/components/DateTimeRangePicker/index.js, packages/form/lib/components/Digit/index.js, packages/form/lib/components/Field/index.js, packages/form/lib/components/Group/index.js, packages/form/lib/components/Radio/index.js, packages/form/lib/components/Rate/index.js, packages/form/lib/components/Select/index.js, packages/form/lib/components/Slider/index.js, packages/form/lib/components/Submitter/index.js, packages/form/lib/components/Switch/index.js, packages/form/lib/components/Text/index.js, packages/form/lib/components/TextArea/index.js, packages/form/lib/components/TimePicker/index.js, packages/form/lib/components/UploadButton/index.js, packages/form/lib/components/UploadDragger/index.js, packages/form/lib/layouts/LightFilter/index.js, packages/form/lib/layouts/ProForm/index.js, packages/form/lib/layouts/QueryFilter/Actions.js, packages/form/lib/layouts/QueryFilter/index.js, packages/form/lib/layouts/StepsFrom/StepFrom.js, packages/form/lib/layouts/StepsFrom/index.js 41.38 KB (0%)
packages/form/es/FieldContext.js, packages/form/es/index.js, packages/form/es/BaseForm/index.js, packages/form/es/BaseForm/LightWrapper/index.js, packages/form/es/components/Checkbox/index.js, packages/form/es/components/DatePicker/DatePicker.js, packages/form/es/components/DatePicker/MonthPicker.js, packages/form/es/components/DatePicker/QuarterPicker.js, packages/form/es/components/DatePicker/WeekPicker.js, packages/form/es/components/DatePicker/YearPicker.js, packages/form/es/components/DatePicker/index.js, packages/form/es/components/DateRangePicker/index.js, packages/form/es/components/DateTimePicker/index.js, packages/form/es/components/DateTimeRangePicker/index.js, packages/form/es/components/Digit/index.js, packages/form/es/components/Field/index.js, packages/form/es/components/Group/index.js, packages/form/es/components/Radio/index.js, packages/form/es/components/Rate/index.js, packages/form/es/components/Select/index.js, packages/form/es/components/Slider/index.js, packages/form/es/components/Submitter/index.js, packages/form/es/components/Switch/index.js, packages/form/es/components/Text/index.js, packages/form/es/components/TextArea/index.js, packages/form/es/components/TimePicker/index.js, packages/form/es/components/UploadButton/index.js, packages/form/es/components/UploadDragger/index.js, packages/form/es/layouts/LightFilter/index.js, packages/form/es/layouts/ProForm/index.js, packages/form/es/layouts/QueryFilter/Actions.js, packages/form/es/layouts/QueryFilter/index.js, packages/form/es/layouts/StepsFrom/StepFrom.js, packages/form/es/layouts/StepsFrom/index.js 34.45 KB (0%)
packages/layout/lib/BasicLayout.js, packages/layout/lib/Footer.js, packages/layout/lib/Header.js, packages/layout/lib/RouteContext.js, packages/layout/lib/WrapContent.js, packages/layout/lib/defaultSettings.js, packages/layout/lib/getPageTitle.js, packages/layout/lib/index.js, packages/layout/lib/typings.js, packages/layout/lib/FooterToolbar/index.js, packages/layout/lib/GlobalFooter/index.js, packages/layout/lib/GlobalHeader/index.js, packages/layout/lib/GridContent/index.js, packages/layout/lib/PageContainer/index.js, packages/layout/lib/PageLoading/index.js, packages/layout/lib/SettingDrawer/BlockCheckbox.js, packages/layout/lib/SettingDrawer/LayoutChange.js, packages/layout/lib/SettingDrawer/RegionalChange.js, packages/layout/lib/SettingDrawer/ThemeColor.js, packages/layout/lib/SettingDrawer/index.js, packages/layout/lib/SiderMenu/BaseMenu.js, packages/layout/lib/SiderMenu/Counter.js, packages/layout/lib/SiderMenu/SiderMenu.js, packages/layout/lib/SiderMenu/SiderMenuUtils.js, packages/layout/lib/SiderMenu/index.js, packages/layout/lib/TopNavHeader/index.js, packages/layout/lib/locales/en-US.js, packages/layout/lib/locales/index.js, packages/layout/lib/locales/it-IT.js, packages/layout/lib/locales/zh-CN.js, packages/layout/lib/locales/zh-TW.js, packages/layout/lib/utils/compatibleLayout.js, packages/layout/lib/utils/getBreadcrumbProps.js, packages/layout/lib/utils/getMenuData.js, packages/layout/lib/utils/pathTools.js, packages/layout/lib/utils/utils.js, packages/layout/lib/locales/en-US/settingDrawer.js, packages/layout/lib/locales/it-IT/settingDrawer.js, packages/layout/lib/locales/zh-CN/settingDrawer.js, packages/layout/lib/locales/zh-TW/settingDrawer.js 53.03 KB (0%)
packages/layout/es/BasicLayout.js, packages/layout/es/Footer.js, packages/layout/es/Header.js, packages/layout/es/RouteContext.js, packages/layout/es/WrapContent.js, packages/layout/es/defaultSettings.js, packages/layout/es/getPageTitle.js, packages/layout/es/index.js, packages/layout/es/typings.js, packages/layout/es/FooterToolbar/index.js, packages/layout/es/GlobalFooter/index.js, packages/layout/es/GlobalHeader/index.js, packages/layout/es/GridContent/index.js, packages/layout/es/PageContainer/index.js, packages/layout/es/PageLoading/index.js, packages/layout/es/SettingDrawer/BlockCheckbox.js, packages/layout/es/SettingDrawer/LayoutChange.js, packages/layout/es/SettingDrawer/RegionalChange.js, packages/layout/es/SettingDrawer/ThemeColor.js, packages/layout/es/SettingDrawer/index.js, packages/layout/es/SiderMenu/BaseMenu.js, packages/layout/es/SiderMenu/Counter.js, packages/layout/es/SiderMenu/SiderMenu.js, packages/layout/es/SiderMenu/SiderMenuUtils.js, packages/layout/es/SiderMenu/index.js, packages/layout/es/TopNavHeader/index.js, packages/layout/es/locales/en-US.js, packages/layout/es/locales/index.js, packages/layout/es/locales/it-IT.js, packages/layout/es/locales/zh-CN.js, packages/layout/es/locales/zh-TW.js, packages/layout/es/utils/compatibleLayout.js, packages/layout/es/utils/getBreadcrumbProps.js, packages/layout/es/utils/getMenuData.js, packages/layout/es/utils/pathTools.js, packages/layout/es/utils/utils.js, packages/layout/es/locales/en-US/settingDrawer.js, packages/layout/es/locales/it-IT/settingDrawer.js, packages/layout/es/locales/zh-CN/settingDrawer.js, packages/layout/es/locales/zh-TW/settingDrawer.js 45.16 KB (0%)
packages/list/lib/Item.js, packages/list/lib/index.js, packages/list/lib/hooks/useLazyKVMap.js, packages/list/lib/hooks/usePagination.js, packages/list/lib/hooks/useSelection.js, packages/list/lib/toolBar/index.js, packages/list/lib/util/getPrefixCls.js 14.56 KB (0%)
packages/list/es/Item.js, packages/list/es/index.js, packages/list/es/hooks/useLazyKVMap.js, packages/list/es/hooks/usePagination.js, packages/list/es/hooks/useSelection.js, packages/list/es/toolBar/index.js, packages/list/es/util/getPrefixCls.js 12.86 KB (0%)
packages/provider/lib/index.js, packages/provider/lib/locale/en_US.js, packages/provider/lib/locale/es_ES.js, packages/provider/lib/locale/fr_FR.js, packages/provider/lib/locale/it_IT.js, packages/provider/lib/locale/ja_JP.js, packages/provider/lib/locale/ms_MY.js, packages/provider/lib/locale/pt_BR.js, packages/provider/lib/locale/ru_RU.js, packages/provider/lib/locale/vi_VN.js, packages/provider/lib/locale/zh_CN.js, packages/provider/lib/locale/zh_TW.js 9.66 KB (0%)
packages/provider/es/index.js, packages/provider/es/locale/en_US.js, packages/provider/es/locale/es_ES.js, packages/provider/es/locale/fr_FR.js, packages/provider/es/locale/it_IT.js, packages/provider/es/locale/ja_JP.js, packages/provider/es/locale/ms_MY.js, packages/provider/es/locale/pt_BR.js, packages/provider/es/locale/ru_RU.js, packages/provider/es/locale/vi_VN.js, packages/provider/es/locale/zh_CN.js, packages/provider/es/locale/zh_TW.js 8.23 KB (0%)
packages/skeleton/lib/index.js, packages/skeleton/lib/component/Descriptions/index.js, packages/skeleton/lib/component/List/index.js, packages/skeleton/lib/component/Result/index.js 4.95 KB (0%)
packages/skeleton/es/index.js, packages/skeleton/es/component/Descriptions/index.js, packages/skeleton/es/component/List/index.js, packages/skeleton/es/component/Result/index.js 3.96 KB (0%)
packages/table/lib/Table.js, packages/table/lib/container.js, packages/table/lib/defaultRender.js, packages/table/lib/index.js, packages/table/lib/useFetchData.js, packages/table/lib/utils.js, packages/table/lib/Form/index.js, packages/table/lib/component/ErrorBoundary.js, packages/table/lib/component/Alert/index.js, packages/table/lib/component/ColumnSetting/DndItem.js, packages/table/lib/component/ColumnSetting/DragIcon.js, packages/table/lib/component/ColumnSetting/index.js, packages/table/lib/component/Dropdown/index.js, packages/table/lib/component/ToolBar/DensityIcon.js, packages/table/lib/component/ToolBar/FullscreenIcon.js, packages/table/lib/component/ToolBar/index.js 37.6 KB (-0.13% 🔽)
packages/table/es/Table.js, packages/table/es/container.js, packages/table/es/defaultRender.js, packages/table/es/index.js, packages/table/es/useFetchData.js, packages/table/es/utils.js, packages/table/es/Form/index.js, packages/table/es/component/ErrorBoundary.js, packages/table/es/component/Alert/index.js, packages/table/es/component/ColumnSetting/DndItem.js, packages/table/es/component/ColumnSetting/DragIcon.js, packages/table/es/component/ColumnSetting/index.js, packages/table/es/component/Dropdown/index.js, packages/table/es/component/ToolBar/DensityIcon.js, packages/table/es/component/ToolBar/FullscreenIcon.js, packages/table/es/component/ToolBar/index.js 32.53 KB (-0.15% 🔽)

@chenshuai2144 chenshuai2144 merged commit e782ffa into master Sep 16, 2020
@chenshuai2144 chenshuai2144 deleted the warning branch September 16, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant