Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Reader: Full nested folder structure shouldn't be required to get date #35

Closed
Antar1011 opened this issue Sep 1, 2016 · 3 comments

Comments

@Antar1011
Copy link
Owner

For testing / dev purposes or just in general, a JsonFileLogReader should be able to pull date information from somewhere besides the folder where the log is stored.

Proposed solution: give JsonFileLogReader a date field that it can fall back to if parsing the folder structure doesn't make sense.

@Antar1011
Copy link
Owner Author

Beginning work on more-flexible-date-parsing branch

@Antar1011
Copy link
Owner Author

Also submitted a PR to PS: smogon/pokemon-showdown#2732

Ofc, with the formats field there's a circular problem here if the strategy is separate readers for separate formats--how do you know which reader should read the log until you read the log?

@Antar1011
Copy link
Owner Author

Just need to add some tests for date-parsing and exception-raising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant