Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditch ORM for SQLAlchemy Core #48

Closed
Antar1011 opened this issue Sep 22, 2016 · 2 comments
Closed

Ditch ORM for SQLAlchemy Core #48

Antar1011 opened this issue Sep 22, 2016 · 2 comments

Comments

@Antar1011
Copy link
Owner

(it's a little premature to put in this issue now, considering the backend branch isn't even in PR yet, much less merged, but since I'm pretty sure I'm going down the ORM route for now, I figure I should put this in before I lose the thread)

As per SQLAlchemy's documentation, ORM operations are slow compared to SQLAlchemy's Expression Language (or executing the SQL directly), so when it comes time to do performance tuning (0.9 milestone), this might be an avenue to pursue. Note that I can still define my tables using the "declarative" idioms--the underlying tables can be accessed via the __table__ attribute.

On the other hand (and the reason I'm not just starting off writing the backend using Core), 12s for 100k rows doesn't actually sound that bad--if I could parse a million logs in a couple of minutes, that would be an enormous improvement on what I have now. Basically what I'm saying is that even doing things the slow ORM way, there's a good chance this won't be a significant bottleneck.

Bottom line: this is something to keep track of, but 50/50 this gets closed as "won't fix"

@Antar1011
Copy link
Owner Author

Working on this on sa-core branch

@Antar1011
Copy link
Owner Author

Resolved by #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant