Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More intelligent missing-rating handling #53

Open
Antar1011 opened this issue Sep 25, 2016 · 0 comments
Open

More intelligent missing-rating handling #53

Antar1011 opened this issue Sep 25, 2016 · 0 comments

Comments

@Antar1011
Copy link
Owner

If a player's rating is missing, it's currently* inferred to be 1500±130 (default rating). The old scripts are smarter than that:

  1. First, they use the player's last known rating
  2. If that's not found, it looks at who won the match and infers a rating based on the single match

Note that this is an "enhancement" not a "feature" because it's not a high priority--I don't think missing ratings are all that common any more (worth checking!), but also the long-term plan is to do player rating calculation locally (not rely on PS).

*again, entering this ticket before the code it's referring to has actually been merged to master or even put in a PR, but yet again, I'm highly confident this code's going to make it in, so entering the ticket now means I won't have to remember later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant