[5.0] fix crash/UB when exceeding http-max-requests-in-flight
#2209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
verify_max_requests_in_flight()
indicates we've exceeded max requests in flight,send_busy_response()
, viasend_response()
, queues up anasync_write()
on the socket. But once thisasync_write()
returns,do_eof()
would be called which closes the socket while operations are pending. This causes bad things to happen.Instead, set the
keep_alive(false)
on the response, which flagsneeds_eof()
so that,leap/plugins/http_plugin/include/eosio/http_plugin/beast_http_session.hpp
Line 478 in 3394e0b
will be set to
true
, which means the socket will be properly disposed of once theasync_write()
completes,leap/plugins/http_plugin/include/eosio/http_plugin/beast_http_session.hpp
Lines 368 to 372 in 3394e0b