Units symbol not registered in CLJS

[zikajk]

My existing code doesn't work in CLJS after updating from "2023.12.15" to "2024.02.27".
b/to-edn doesn't recognize unit symbols properly.

[2food]

Hi @zikajk. Sorry about that. I've had some trouble with getting the cljs implementation working right. But I think I've got it right in the latest release "2024.02.29". Could you give that a try and see if it works for you?

[zikajk]

Hi @2food, it looks good, thank you.
I had to optimize some code to check on new type broch.numbers/JSRatio and so far no problems.
What would be the recommended way to display JSRatio as a string ("#.#######") in your opinion?

[zikajk]

I tried to use b/boxed on jsRation but I have some issues
No protocol method IQuantity.number defined for type broch.numbers/JSRatio: 82000000/707107

[2food]

Hi @zikajk ,

What would be the recommended way to display JSRatio as a string ("#.#######") in your opinion?
I think the default way "1/3" is often fine, but you can truncate it to a float with broch.number/js-ratio->number as well.

I tried to use b/boxed on jsRation but I have some issues
No protocol method IQuantity.number defined for type broch.numbers/JSRatio: 82000000/707107

From the error it looks like you're calling b/boxed on a JSRatio rather than on a quantity. Most functions in broch.core can take numbers in place of quantities, but I see that this is not the case for JSRatio as it's not a "normal" number. So this is a bug, I'll fix it to include JSRatios in the next release.

Thanks for your comments and sorry for the very late response.