Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'target' for emails #91

Open
russcarver opened this issue Jun 2, 2019 · 2 comments
Open

Add 'target' for emails #91

russcarver opened this issue Jun 2, 2019 · 2 comments
Assignees

Comments

@russcarver
Copy link

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ x] feature request

OS and Version? I'm on macOS 10.14.5 Mojave (but this shouldn't matter)

Versions

Angular CLI: 7.3.9
Node: 10.15.3
OS: darwin x64
Angular: 5.2.11
... animations, common, compiler, compiler-cli, core, forms
... http, platform-browser, platform-browser-dynamic
... platform-server, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.13.9 (cli-only)
@angular-devkit/build-optimizer   0.0.35
@angular-devkit/core              7.3.9 (cli-only)
@angular-devkit/schematics        7.3.9 (cli-only)
@schematics/angular               7.3.9 (cli-only)
@schematics/update                0.13.9 (cli-only)
rxjs                              5.5.12
typescript                        2.7.2
webpack                           3.10.0

Repro steps

I'm using this with Angular5 and Ionic3 (a hybrid mobile app). So when the user clicks on an email, I don't want the app (which runs in a browser) replaced by the email client. Please add the 'target' option for 'email' so that it can be '_blank'. Linkify shows that 'target' can specify 'email' (https://soapbox.github.io/linkifyjs/docs/options.html#target)

The log given by the failure

N/A

Desired functionality

The email app/page should open in a new tab.

Mention any other details that might be useful

N/A

@AnthonyNahas
Copy link
Owner

@russcarver thanks for opening this issue! I will appreciate your PR 👍 thank you

@jesscrees
Copy link

Would you also be able to add target for the other link types of hashtag and mention please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants