Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Once we get community notations, create a different section for those compared to those in game. #22

Closed
earthernsence opened this issue Sep 8, 2019 · 3 comments

Comments

@earthernsence
Copy link
Member

You could either keep it centered and have a header for community ones, or you could separate them into different columns.

@dan-simon
Copy link
Collaborator

Just to check, is it the consensus that community notations won't be added to the game? Assuming the game is going to use this library, it'll load any community notations added to this library anyway.

@earthernsence
Copy link
Member Author

Just to check, is it the consensus that community notations won't be added to the game? Assuming the game is going to use this library, it'll load any community notations added to this library anyway.

I believe so.

@dan-simon
Copy link
Collaborator

Ok so I can add make PRs for my cringey notation ideas without needing to die from embarrassment due to people actually seeing the notations in practice, good to know

More seriously, it would be cool if importing a community notation name would switch the game to that notation, like with secret themes. Of course, if there's some way to stop the community notations from even being loaded (like an alternate light version of the library without the community notations, or AD not actually using the library), then importing the community notations is probably a bad idea due to increased load time. Also, maybe importing notations is difficult or impossible to code for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants