Make >>- operator precedence compatible with other frameworks. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes it more similar to Haskell, see thoughtbot/Runes#30. These frameworks have made this change: - thoughtbot/Runes@d3a7d63 - robrix/Either#28 - robrix/Madness#86
kareman
added a commit
to kareman/FootlessParser
that referenced
this pull request
May 23, 2015
Result is once again an enum. Also this removes 3 frameworks that are no longer needed ("id" was previously in Prelude).
Runes has new precedence for operators (thoughtbot/Runes#30):
infix operator <^> { associativity left precedence 130 }
infix operator <*> { associativity left precedence 130 }
infix operator >>- { associativity left precedence 100 }
infix operator -<< { associativity right precedence 100 }
This means Result must use the same precedence for >>- . Hopefully this pull request will be accepted: antitypical/Result#49 . In the meantime we have to use my own fork https://github.com/kareman/Result/tree/flatmap-operator-precedence.
|
👍 |
robrix
added a commit
that referenced
this pull request
May 24, 2015
Make >>- operator precedence compatible with other frameworks.
|
Btw, do you know if the comment above the changed line is still correct? |
|
Prelude is defining function application at 95, and composition at 170, so that comment still holds true. |
kareman
added a commit
to kareman/FootlessParser
that referenced
this pull request
May 26, 2015
Switch back to using https://github.com/antitypical/Result as pull request antitypical/Result#49 was accepted and it now is using precedence 100 for the >>- operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Runes framework has changed its >>- operator precedence to be more like Haskells, see thoughtbot/Runes#30. This means you can't use Runes, Result and >>- in the same Swift file because the compiler complains about ambiguous operator precedence definitions. I ran into this problem with a version of Gordon Fontenots implementation of <*> and <^> for Result.
robrix/Either#28 and robrix/Madness#86 have also made the same change.