Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates all dependencies used in Dockerfile and fix Docker image #507

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

MaxymVlasov
Copy link
Collaborator

@MaxymVlasov MaxymVlasov commented Apr 20, 2023

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

Description of your changes

Previous curl version in docker image was removed

Fixes #506
Fixes #488

How can we test changes

Copy link
Collaborator

@yermulnik yermulnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite this is Draft PR, I'm approving this if @MaxymVlasov finds this change to be feasible and non-breaking.

@MaxymVlasov MaxymVlasov changed the title fix: Update curl docker image fix: checkov in Docker image and update all dependencies in Docker image Apr 21, 2023
@github-actions

This comment was marked as outdated.

There is no posibility to exclude part of "pre-installed" files from
COPY step like moby/buildkit#2853
And copy-paste mostly all `site-packages` without it is not worth it
@MaxymVlasov MaxymVlasov marked this pull request as ready for review April 21, 2023 13:08
@MaxymVlasov MaxymVlasov changed the title fix: checkov in Docker image and update all dependencies in Docker image fix: Updates all dependencies used in Dockerfile and fix Docker image Apr 21, 2023
@MaxymVlasov MaxymVlasov merged commit dc177fe into master Apr 21, 2023
@MaxymVlasov MaxymVlasov deleted the fix/docker_image branch April 21, 2023 13:27
antonbabenko pushed a commit that referenced this pull request Apr 21, 2023
## [1.77.3](v1.77.2...v1.77.3) (2023-04-21)

### Bug Fixes

* Updates all dependencies used in Dockerfile and fix Docker image ([#507](#507)) ([dc177fe](dc177fe))
@antonbabenko
Copy link
Owner

This PR is included in version 1.77.3 🎉

lexton pushed a commit to lexton/pre-commit-terraform that referenced this pull request Apr 28, 2023
## [1.77.3](antonbabenko/pre-commit-terraform@v1.77.2...v1.77.3) (2023-04-21)

### Bug Fixes

* Updates all dependencies used in Dockerfile and fix Docker image ([antonbabenko#507](antonbabenko#507)) ([dc177fe](antonbabenko@dc177fe))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with curl version 7 in Dockerfile Latest image broken
3 participants