-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser error on 386 arch by int overflows #64
Comments
Looks like Antlr generated code doesn't support 32 bit arch. I think this is Antlr issue. |
@antonmedv I tried to update Go. Антон, на одной машине у нас все ОК, на другой такая ошибка. Может как то заставить Antlr перегенерировать код? |
@antonmedv the related issue in Antlr antlr/antlr4#2433 |
Yes, I think this is only possible to solve it, by solving issue at Antlr. It's really difficult to patch already generated code. |
@antonmedv Strange to see when at one computer it works and at another it fails... looks odd |
Yes, but |
This antlr project doesn't seem to be very interested in this issue, I'm thinking, would it make sense to enforce int32 everywhere within this package? |
Hmm, why to enforce? I’m thinking about rewriting parser from the scratch actually. |
I guess my thinking is a bit premature without actually doing any research. I guess I was thinking that since this is an overflow error, it's likely that somewhere in this package int/int64 was used that then is passed into antlr. But once I read your comment I realised that this could equally be happening inside the antlr project. |
Pending resolution of these issues: - expr-lang/expr#64 - antlr/antlr4#2433
Fixed. I've rewritten the entire parser for this. :) |
@antonmedv Is it here a3582e9 ? |
Yes. |
Спасибо! |
Windows 7 32-bit
go1.11.2 windows/386
Trying to do:
Build fails with multiple errors:
The text was updated successfully, but these errors were encountered: