Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a mistake in the DARTS code #4

Closed
xiangzhluo opened this issue May 18, 2020 · 1 comment
Closed

There is a mistake in the DARTS code #4

xiangzhluo opened this issue May 18, 2020 · 1 comment

Comments

@xiangzhluo
Copy link

Hi,

I just find there is a mistake in your released DARTS code.

In architect.py, the hessian is computed as follows:
hessian = [(p-n) / 2.*eps for p, n in zip(dalpha_pos, dalpha_neg)]

However, referring to paper and the official release code, it should be computed as follows:
hessian = [(p-n) / (2.*eps) for p, n in zip(dalpha_pos, dalpha_neg)]

But it seems this mistake does not hurt the performance. LOL

@antoyang
Copy link
Owner

antoyang commented Jun 18, 2020

Hi, thanks for noticing. I corrected it. You may as well warn the original repo of DARTS that I refer to in the Readme though. I am not too surprised that the performance is not much affected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants