Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there any advantage to having conversion functions for non resources registered to the schema #1616

Closed
tnqn opened this issue Dec 4, 2020 · 3 comments
Closed

Is there any advantage to having conversion functions for non resources registered to the schema #1616

tnqn opened this issue Dec 4, 2020 · 3 comments
Labels
good first issue Good for newcomers lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@tnqn
Copy link
Member

tnqn commented Dec 4, 2020 •
edited
Loading

Is there any advantage to having conversion functions for non resources registered to the schema? I understand why Convert_controlplane_AddressGroup_To_v1beta1_AddressGroup needs to be registered, but it seems conversion functions for non resources will only be called indirectly by other conversion functions. Is it for auto-generated conversion functions?

Originally posted by @antoninbas in #1586 (comment)
@tnqn tnqn mentioned this issue Dec 4, 2020
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2021

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment, or this will be closed in 180 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2021
@tnqn tnqn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment, or this will be closed in 180 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 1, 2021
@antoninbas antoninbas added good first issue Good for newcomers and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antoninbas @tnqn