Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(g-canvas): bbox calculation should be correct for path when angle is null, 0 and PI #265

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

dengfuping
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 🐞 [g-canvas] Fix that bbox calculation is not correct for path when angle is null, 0 and PI. #254
🇨🇳 Chinese 🐞 [g-canvas] 修复 path 的夹角为空、0 和 PI 时,包围盒计算不正确的问题。#254

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Nov 20, 2019

Deploy preview for antv-g ready!

Built with commit 5a02d10

https://deploy-preview-265--antv-g.netlify.com

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 20, 2019

This pull request fixes 1 alert when merging 5a02d10 into 250f54d - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@dxq613 dxq613 merged commit f90e848 into 4.x Nov 20, 2019
@dxq613 dxq613 deleted the fix-issue-254 branch November 20, 2019 05:42
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
fix(g-canvas): bbox calculation should be correct for path when angle is null, 0 and PI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants