feat(tooltip): 通过 pointer-events 属性来达到 tooltip 躲避鼠标的交互效果 #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustcc
reviewed
Mar 23, 2020
src/chart/controller/tooltip.ts
Outdated
| const theme = view.getTheme(); | ||
| const defaultCfg = get(theme, ['components', 'tooltip'], {}); | ||
| return deepMix({}, defaultCfg, option); | ||
| const isTooltipLocked = view.isTooltipLocked(); | ||
| const pointerEvents = (get(option, 'enterable') || isTooltipLocked) ? 'auto' : (defaultCfg.enterable ? 'auto' : 'none'); |
There was a problem hiding this comment.
语意上等同于 下面吗？
// 主要是这里，用户配置就用用户的，没有就去默认值。
const enterable = get(option, 'enterable') || defaultCfg.enterable
const pointerEvents = enterable || isTooltipLocked ？ 'auto' : 'none';There was a problem hiding this comment.
语意上等同于 下面吗？
// 主要是这里，用户配置就用用户的，没有就去默认值。 const enterable = get(option, 'enterable') || defaultCfg.enterable const pointerEvents = enterable || isTooltipLocked ？ 'auto' : 'none';
不等于，因为 enterable 是以用户设置的为准。
dxq613
reviewed
Mar 23, 2020
| } | ||
|
|
||
| // 获取 tooltip 配置，因为用户可能会通过 view.tooltip() 重新配置 tooltip，所以就不做缓存，每次直接读取 | ||
| private getTooltipCfg() { | ||
| const view = this.view; | ||
| const option = this.option; |
There was a problem hiding this comment.
lockTooltip 时，不一定会调用 showTooltip，这时候 pointEvent 不会变成 'auto'，每次 tooltip show 时都更新 domStyle 成本有些高。
There was a problem hiding this comment.
tooltip 组件不会进行比对吗？domStyles 未发生改变不进行更新？
simaQ
force-pushed
the
tooltip-pointer-events
branch
from
c85fb65
to
1e4e0ba
Compare
|
This pull request introduces 1 alert when merging 8d3b0d5 into d835f18 - view on LGTM.com new alerts:
|
dxq613
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.