Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI 插件迁移 - Fisheye #4582

Closed
1 task done
Yanyan-Wang opened this issue Jun 5, 2023 · 4 comments
Closed
1 task done

UI 插件迁移 - Fisheye #4582

Yanyan-Wang opened this issue Jun 5, 2023 · 4 comments
Assignees
Labels
Claimed/已认领 Reward/悬赏 Reward for issue hunter

Comments

@Yanyan-Wang
Copy link
Contributor

Issue Hunt 计划(可选)

  • 我同意将这个 Issue 参与 Issue Hunt 计划

Issue 难度

中等难度

悬赏

请在 2023 年 7 月 1 日之前完成 PR,7 月 15 日之前完成全部 CR 意见的修改。

AntV 将支付 $20 (汇率按结算当日计)

问题描述

G6 4.x 中的 Fisheye 插件 迁移到 5.0 中,注意:

4.x 的 plugin 在 5.0 属于自由插件模块,参考 5.0 Minimap 的实现:https://github.com/antvis/G6/blob/v5/packages/g6/src/stdlib/plugin/minimap/index.ts

  • 继承 Base Plugin;

  • 保留 4.x Fisheye 所有能力和配置;

重现链接

https://github.com/antvis/G6/blob/v5/packages/g6/src/stdlib/plugin/minimap/index.ts

重现步骤

  1. clone g6 代码
git clone https://github.com/antvis/G6.git
  1. 拉取所有线上分支
git fetch
  1. 切换到 v5 分支
git checkout v5
  1. 进入 g6 包
cd packages/g6
  1. 安装依赖
npm install
  1. 启动 demo
npm run dev
  1. 实现功能、新增 demo 以测试

demo 位于 packages/g6/tests/integration

  1. 提交代码,等待 CR

  2. 根据(多次) CR 建议修改

  3. 等待合并入 v5 分支后,管理员支付奖金

预期行为

G6 4.x 中的 Fisheye 插件 迁移到 5.0 中,注意:

4.x 的 plugin 在 5.0 属于自由插件模块,参考 5.0 Minimap 的实现:https://github.com/antvis/G6/blob/v5/packages/g6/src/stdlib/plugin/minimap/index.ts

  • 继承 Base Plugin;

  • 保留 4.x Fisheye 所有能力和配置;

平台

  • 操作系统: [macOS, Windows, Linux, React Native ...]
  • 网页浏览器: [Google Chrome, Safari, Firefox]
  • G6 版本: [5.0-alpha]

屏幕截图或视频(可选)

No response

补充说明(可选)

No response

@Yanyan-Wang Yanyan-Wang added Reward/悬赏 Reward for issue hunter $20 labels Jun 5, 2023
@Yanyan-Wang Yanyan-Wang added this to the [2023/07]Issue Hunt milestone Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

请复制以下模板,填写相关信息,然后删除模板中的注释。
Please copy the following template, fill in the relevant information, and then delete the comments in the template.


## Issue 认领 / Issue Claim

**贡献者/Contributor**

> 例如:张三, 李四
> For example: John Smith, Sarah Johnson

**预计完成时间/Estimated Completion Date**

> 例如:2023-06-06
> For example: May 30, 2023

**联系方式/Contact Information**

> 例如:contact@email.com
> For example: contact@email.com

**其他信息/Additional Information**

> 例如:这个 issue 比预期的要复杂,我希望能获得更多的奖励
> For example: This issue is more complex than expected, and I hope to receive more reward.

@lionztt
Copy link
Contributor

lionztt commented Jun 28, 2023

Issue 认领

贡献者
lionztt

预计完成时间
2023-6-30

联系方式
lionztt@163.com

其他信息
目前这个issus,我这边有一些问题能否加群细问一些问题呢

@lionztt
Copy link
Contributor

lionztt commented Jun 29, 2023

@Yanyan-Wang hello,不好意思打扰啦,想问一下咱们v5要怎么获取group呢?原有的graph.get('group')应该是已经换掉了....还有v5中怎么在group中添加shape呢,addShape这个函数也不能用了....

@Yanyan-Wang
Copy link
Contributor Author

Yanyan-Wang commented Jul 14, 2023

感谢 @lionztt ,该任务已经完成:#4696

已完成付款~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Claimed/已认领 Reward/悬赏 Reward for issue hunter
Projects
Development

No branches or pull requests

2 participants