Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw doc #283

Merged
merged 16 commits into from
Apr 21, 2020
Merged

Draw doc #283

merged 16 commits into from
Apr 21, 2020

Conversation

lzxue
Copy link
Contributor

@lzxue lzxue commented Apr 14, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lgtm-com
Copy link

lgtm-com bot commented Apr 14, 2020

This pull request introduces 2 alerts when merging 865e1fe into 12fefa3 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 18, 2020

This pull request introduces 2 alerts when merging 998ca7c into e5860d7 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 20, 2020

This pull request introduces 2 alerts when merging 0b83a3b into e53684a - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2020

This pull request introduces 3 alerts and fixes 1 when merging c1a395b into ed934a0 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2020

This pull request introduces 3 alerts and fixes 1 when merging 74ffccc into ed934a0 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lzxue lzxue merged commit 3cd60d7 into master Apr 21, 2020
@lzxue lzxue deleted the draw_doc branch April 21, 2020 07:52
@pr-triage pr-triage bot added the PR: merged label Apr 21, 2020
lzxue added a commit that referenced this pull request Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant