fix: 修复react key为null时diff错误

antvis · Oct 29, 2021 · 5c9c8ad · 5c9c8ad
1 parent 31f0a35
commit 5c9c8ad
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 7 deletions.
diff --git a/packages/f2-next/src/children.ts b/packages/f2-next/src/children.ts
@@ -1,4 +1,4 @@
-import { isArray } from '@antv/util';
+import { isArray, isNil } from '@antv/util';
 import { map } from './util';
 
 function cloneElement(element, props) {
@@ -22,7 +22,7 @@ function compareArray(
   const lastLength = lastElements.length;
   for (let i = 0, len = lastLength; i < len; i++) {
     const element = lastElements[i];
-    if (element && element.key !== undefined) {
+    if (element && !isNil(element.key)) {
       const { key } = element;
       keyed[key] = element;
     }
@@ -37,7 +37,7 @@ function compareArray(
     }
     const { key } = element;
     // 有key值定义
-    if (key !== undefined) {
+    if (!isNil(element.key)) {
       const lastElement = keyed[key];
       if (lastElement) delete keyed[key];
       compare(element, lastElement, callback);

diff --git a/packages/f2-next/src/components/line/lineView.tsx b/packages/f2-next/src/components/line/lineView.tsx
@@ -11,10 +11,19 @@ export default (props: any) => {
             {dataArray.map((data) => (
               <polyline
                 attrs={{
-                  points: data,
-                  stroke:  color,
-                  lineWidth:size,
-                  ...shape
+                  points: data.map((item) => {
+                    return { x: item.x, y: item.y };
+                  }),
+                  stroke: color,
+                  lineWidth: size,
+                  ...shape,
+                }}
+                animation={{
+                  update: {
+                    easing: 'linear',
+                    duration: 450,
+                    property: ['points'],
+                  },
                 }}
               />
             ))}