Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 调整Geometry里面scale的更新顺序 #1452

Merged
merged 1 commit into from
Apr 22, 2022
Merged

fix: 调整Geometry里面scale的更新顺序 #1452

merged 1 commit into from
Apr 22, 2022

Conversation

ACERY1
Copy link
Member

@ACERY1 ACERY1 commented Apr 21, 2022

现在geom里面有三个步骤会更新scale，顺序是：

  1. createAttrs 更新 scale（ 默认nice:true )
  2. adjust = stack 更新scale（更新min、max）
  3. 饼图 更新 scale（nice: false )

正确的顺序应该是 ： 1 3 2

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@zengyue zengyue merged commit 7ef9e86 into master Apr 22, 2022
@zengyue zengyue deleted the ms/fix/pieBug branch April 22, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ACERY1 @zengyue