Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 修复 image 绘制的层级问题. Closed #1489 #1490

Merged
merged 1 commit into from
May 22, 2022
Merged

fix: 修复 image 绘制的层级问题. Closed #1489 #1490

merged 1 commit into from
May 22, 2022

Conversation

zengyue
Copy link
Member

@zengyue zengyue commented May 20, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

accesslint[bot]
accesslint bot reviewed May 20, 2022
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

packages/f2/test/canvas/graphic.test.tsx
const { props } = (
<Canvas context={context} animate={false} pixelRatio={1}>
<group>
<image
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

@zengyue zengyue merged commit 5549c5d into master May 22, 2022
@zengyue zengyue deleted the fix-1489 branch May 22, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zengyue